Skip to content

Conversation

@zsxwing
Copy link
Member

@zsxwing zsxwing commented Oct 20, 2014

zeroValue will be serialized by spark.closure.serializer but spark.closure.serializer only supports the default Java serializer. So it must not be ClassWithoutNoArgConstructor, which can not be serialized by the Java serializer.

This PR changed zeroValue to null and updated the test to make it work correctly.

@SparkQA
Copy link

SparkQA commented Oct 20, 2014

QA tests have started for PR 2856 at commit 51da655.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Oct 20, 2014

QA tests have finished for PR 2856 at commit 51da655.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21915/
Test PASSed.

@aarondav
Copy link
Contributor

LGTM, merging into master - thanks!

@asfgit asfgit closed this in 1536d70 Oct 29, 2014
@zsxwing zsxwing deleted the SPARK-4008 branch October 29, 2014 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants