Skip to content

[SPARK-4008] Fix "kryo with fold" in KryoSerializerSuite #2856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zsxwing wants to merge 1 commit into from
Closed

[SPARK-4008] Fix "kryo with fold" in KryoSerializerSuite #2856

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions core/src/test/scala/org/apache/spark/serializer/KryoSerializerSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,12 +201,17 @@ class KryoSerializerSuite extends FunSuite with SharedSparkContext {
assert(control.sum === result)
}

// TODO: this still doesn't work
ignore("kryo with fold") {
test("kryo with fold") {
val control = 1 :: 2 :: Nil
// zeroValue must not be a ClassWithoutNoArgConstructor instance because it will be
// serialized by spark.closure.serializer but spark.closure.serializer only supports
// the default Java serializer.
val result = sc.parallelize(control, 2).map(new ClassWithoutNoArgConstructor(_))
.fold(new ClassWithoutNoArgConstructor(10))((t1, t2) => new ClassWithoutNoArgConstructor(t1.x + t2.x)).x
assert(10 + control.sum === result)
.fold(null)((t1, t2) => {
val t1x = if (t1 == null) 0 else t1.x
new ClassWithoutNoArgConstructor(t1x + t2.x)
}).x
assert(control.sum === result)
}

test("kryo with nonexistent custom registrator should fail") {
Expand Down