[SPARK-35315][TESTS] Keep benchmark result consistent between spark-submit and SBT #32440
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
cc @dongjoon-hyun @viirya @HyukjinKwon found this while running benchmark through Github actions. |
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
wangyum
approved these changes
May 5, 2021
|
Test build #138143 has finished for PR 32440 at commit
|
HyukjinKwon
approved these changes
May 5, 2021
Member
|
Merged to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Set
IS_TESTINGto true inBenchmarkBase, before running benchmarks.Why are the changes needed?
Currently benchmark can be done via 2 ways:
spark-submit, or SBT command. However in the former Spark will miss some properties such asIS_TESTING, which is necessary to turn on/off certain behavior like codegen (spark.sql.codegen.factoryMode). Therefore, the result could differ between the two. In addition, the benchmark GitHub workflow is using the spark-submit approach.Does this PR introduce any user-facing change?
No
How was this patch tested?
N/A