Skip to content

[SPARK-35315][TESTS] Keep benchmark result consistent between spark-submit and SBT #32440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sunchao wants to merge 1 commit into from
Closed

[SPARK-35315][TESTS] Keep benchmark result consistent between spark-submit and SBT #32440

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
first commit
  • Loading branch information
@sunchao
sunchao committed May 4, 2021
commit f7680a460f8058b4d1b3ab39eef61c0134d9abe2
6 changes: 6 additions & 0 deletions core/src/test/scala/org/apache/spark/benchmark/BenchmarkBase.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ package org.apache.spark.benchmark

import java.io.{File, FileOutputStream, OutputStream}

import org.apache.spark.internal.config.Tests.IS_TESTING

/**
* A base class for generate benchmark results to a file.
* For JDK9+, JDK major version number is added to the file names to distinguish the results.
Expand All @@ -42,6 +44,10 @@ abstract class BenchmarkBase {
}

def main(args: Array[String]): Unit = {
// turning this on so the behavior between running benchmark via `spark-submit` or SBT will
// be consistent, also allow users to turn on/off certain behavior such as
// `spark.sql.codegen.factoryMode`
System.setProperty(IS_TESTING.key, "true")
val regenerateBenchmarkFiles: Boolean = System.getenv("SPARK_GENERATE_BENCHMARK_FILES") == "1"
if (regenerateBenchmarkFiles) {
val version = System.getProperty("java.version").split("\\D+")(0).toInt
Expand Down