Skip to content

[SPARK-35664][SQL] Support java.time.LocalDateTime as an external type of TimestampWithoutTZ type #32814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gengliangwang wants to merge 7 commits into from
Closed

[SPARK-35664][SQL] Support java.time.LocalDateTime as an external type of TimestampWithoutTZ type #32814

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0533fb8
use LocalDateTime as external type for TimestampWithoutTZType
gengliangwang Jun 8, 2021
c2ebb06
address comment
gengliangwang Jun 8, 2021
ba44cb1
revise test case
gengliangwang Jun 8, 2021
264c693
Update sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util…
gengliangwang Jun 8, 2021
0418133
exact
gengliangwang Jun 8, 2021
35b78f1
retrigger test
gengliangwang Jun 9, 2021
a2326e0
update jira id
gengliangwang Jun 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
update jira id
  • Loading branch information
@gengliangwang
gengliangwang committed Jun 9, 2021
commit a2326e0abc8cca80032213476d53ee5b0b9228ea
4 changes: 2 additions & 2 deletions sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/DateTimeUtilsSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -634,7 +634,7 @@ class DateTimeUtilsSuite extends SparkFunSuite with Matchers with SQLHelper {
}
}

test("SPARK-35099: microseconds to LocalDateTime") {
test("SPARK-35664: microseconds to LocalDateTime") {
assert(microsToLocalDateTime(0) == LocalDateTime.parse("1970-01-01T00:00:00"))
assert(microsToLocalDateTime(100) == LocalDateTime.parse("1970-01-01T00:00:00.0001"))
assert(microsToLocalDateTime(100000000) == LocalDateTime.parse("1970-01-01T00:01:40"))
Expand All @@ -647,7 +647,7 @@ class DateTimeUtilsSuite extends SparkFunSuite with Matchers with SQLHelper {
LocalDateTime.parse("+294247-01-10T04:00:54.775807"))
}

test("SPARK-35099: LocalDateTime to microseconds") {
test("SPARK-35664: LocalDateTime to microseconds") {
assert(DateTimeUtils.localDateTimeToMicros(LocalDateTime.parse("1970-01-01T00:00:00")) == 0)
assert(
DateTimeUtils.localDateTimeToMicros(LocalDateTime.parse("1970-01-01T00:00:00.0001")) == 100)
Expand Down