Skip to content

Conversation

@Swinky
Copy link
Contributor

@Swinky Swinky commented Jun 27, 2021

What changes were proposed in this pull request?

Update exprId for IN subquery for DPP in executed plan; to have same expr Id as DynamicPruning filter in optimized plan.

Why are the changes needed?

This minor change shall make debugging easier in complex queries.

Does this PR introduce any user-facing change?

Yes, just exprId changes in the optimized and executed plans. Now both shall have same exprId for an DPP expression/subquery.

How was this patch tested?

Added a check in existing UTs.

@github-actions github-actions bot added the SQL label Jun 27, 2021
@Swinky
Copy link
Contributor Author

Swinky commented Jun 27, 2021

@maryannxue, could you please have a look at this, thanks!

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@HyukjinKwon
Copy link
Member

@Swinky can you take a look https://github.com/apache/spark/pull/33110/checks?check_run_id=2926460223 and enable Github Actions in your fork repository?

@HyukjinKwon HyukjinKwon changed the title [SPARK-35911] DPP: Update exprId for IN subquery [SPARK-35911][SQL] Update exprId for IN subquery in DPP Jun 28, 2021
@Swinky
Copy link
Contributor Author

Swinky commented Jun 28, 2021

@Swinky can you take a look https://github.com/apache/spark/pull/33110/checks?check_run_id=2926460223 and enable Github Actions in your fork repository?

@HyukjinKwon,
I made sure that my branch is based on latest master and GitHub Actions are already enabled. Not sure why this is still failing.
image

image

@HyukjinKwon
Copy link
Member

@Swinky did you face something like #32400 (comment)? otherwise rebasing would retrigger the build properly

@github-actions
Copy link

We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!

@github-actions github-actions bot added the Stale label Oct 21, 2021
@github-actions github-actions bot closed this Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants