Skip to content

Conversation

@Dobiasd
Copy link
Contributor

@Dobiasd Dobiasd commented Apr 29, 2021

What changes were proposed in this pull request?

Fixing some typos in the documenting comments.

Why are the changes needed?

To make reading the docs more pleasant.

Does this PR introduce any user-facing change?

Yes, since the user sees the docs.

How was this patch tested?

It was not tested, because no code was changed.

@HyukjinKwon
Copy link
Member

This is fine but @Dobiasd:

  1. would you mind taking a look and see if there are more typos since we're here?
  2. Also, please keep the GitHub pull request template.
  3. Please take a look for https://github.com/apache/spark/pull/32400/checks?check_run_id=2467844791 and enable GItHub Actions for your repository so your PR can be properly tested.

@HyukjinKwon HyukjinKwon changed the title Fix a typo in the documentation of GroupState [MINOR][SS][DOCS] Fix a typo in the documentation of GroupState May 3, 2021
@Dobiasd
Copy link
Contributor Author

Dobiasd commented May 3, 2021

@HyukjinKwon Thanks for the help. 👍

  • GitHub actions already was enabled for my forked repo: https://i.imgur.com/CTEkw1R.png
  • I've rebased my branch on upstream master and force-pushed as described.
  • My comment is updated now, using the template.
  • Using Grammarly, I've fixed some more typos in the comments of GroupState.scala.

@HyukjinKwon
Copy link
Member

ok to test

@HyukjinKwon
Copy link
Member

HyukjinKwon commented May 3, 2021

Thanks @Dobiasd. It's weird that your forked repository doesn't run the tests at https://github.com/Dobiasd/spark/actions .. your branch looks sync'ed with the latest Apache Spark master branch too hm

@HyukjinKwon
Copy link
Member

Hm, but the tests should pass though before merging it in. Do other repositories of yours run GitHub Actions workflows properly?

@HyukjinKwon
Copy link
Member

Oh, I can see now: https://github.com/Dobiasd/spark/actions. Would you mind squahsing your comments and pushing it into this PR? e.g.) git rebase upstream/master -i, mark the second commit as s, and git push origin patch-1 --force

@Dobiasd
Copy link
Contributor Author

Dobiasd commented May 3, 2021

Ah, when going directly to https://github.com/Dobiasd/spark/actions, it showed this: https://i.imgur.com/NA9PgLB.png

I've clicked on "I understand my workflows, go ahead and enable them". So it should be working now. 🙂

@Dobiasd
Copy link
Contributor Author

Dobiasd commented May 3, 2021

The changes are squashed into one commit now. ✔️

@HyukjinKwon
Copy link
Member

Merged to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants