-
Notifications
You must be signed in to change notification settings - Fork 29k
Add docs about using Shiv for packaging (similar to PEX) #34083
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Let's create another section instead of reusing PEX, and make sure testing on Yarn cluster/client, K8S cluster/client and standalone modes (all options here are manually tested by me). cc @mridulm and @xkrogen who might have a better context on this. cc @fhoering for PEX. |
|
ok to test |
|
for the PR itself,
|
|
Test build #143578 has finished for PR 34083 at commit
|
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
|
Agree with @HyukjinKwon - it would be good to start a discussion in spark mailing lists as well. |
|
+CC @zhouyejoe |
|
Hi, @HyukjinKwon. Thanks for reviewing it. We have tested in YARN cluster mode. Will check with client mode, and also K8s cluster/client mode, standalone mode. |
|
Just a simple job is good enough. E.g., running a pandas udf example mentioned in the docs. BTW, let's make a separate section instead of reusing PEX in the docs. |
|
Thanks @HyukjinKwon for reviewing. I will update the change to discuss Shiv in a separate section. Regarding the GitHub Actions setup. I think I have them enabled: But for some reason they're not triggering. |
|
did you face something like #32400 (comment)? otherwise rebasing would retrigger the build properly. |
The Shiv packaging tool works similarly to PEX and can be used to distribute Python with its dependencies in an executable. These changes mention Shiv and demonstrate it's use similar to the PEX project.
c93ec6f to
ad978fe
Compare
|
Yes, I missed that. I've clicked Ok on the /actions page and rebased my change to trigger the build. Thank you. |
|
Kubernetes integration test starting |
|
Test build #143663 has finished for PR 34083 at commit
|
|
Kubernetes integration test status failure |
|
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. |
|
Looks like this got dropped from our review radar @HyukjinKwon. |
|
@mridulm I think we can reopen this until we have done enough testing around using Shiv here. Thoughts? |
|
Sounds good, we can revisit the PR once we have validated things. |
Shall we add a JIRA ticket for this? |

What changes were proposed in this pull request?
The Shiv packaging tool works similarly to PEX and can be used to distribute Python with its dependencies in an executable. These changes mention Shiv and demonstrate it's use similar to the PEX project.
Why are the changes needed?
Shiv is a widely used packaging tool similar to PEX. These changes mention Shiv as an alternative tool.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
No code changes.