[SPARK-40294][SQL] Fix repeat calls to PartitionReader.hasNext timing out
#37743
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardc-db
changed the title
PartitionReader.hasNext timing outPartitionReader.hasNext timing out
|
Can one of the admins verify this patch? |
Contributor
|
Does DSv1 have similar problems? |
cloud-fan
reviewed
Sep 15, 2022
| reader: PartitionReader[T], | ||
| customMetrics: Map[String, SQLMetric]) extends Iterator[T] { | ||
| private[this] var valuePrepared = false | ||
| private[this] var prevHasNext = true |
Contributor
There was a problem hiding this comment.
I think hasMoreInput is a better name.
cloud-fan
reviewed
Sep 15, 2022
| private var numRow = 0L | ||
|
|
||
| override def hasNext: Boolean = { | ||
| if (!valuePrepared) { |
Contributor
There was a problem hiding this comment.
can you follow the change in https://github.com/apache/spark/pull/37900/files ? It can avoid entering this if branch entirely.
Contributor
|
ping @richardc-db |
Member
|
Closed in favor of #37743 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This change ensures that, once
PartitionReader.hasNextreturns false once, subsequent calls toPartitionReader.hasNextwill not callreader.next()(which before could cause a timeout).Why are the changes needed?
This change prevents potential performance regressions caused by parent nodes that call
PartitionIterator.hasNexteven after it returns false once.Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing tests