[SPARK-40456][SQL] PartitionIterator.hasNext should be cheap to call repeatedly #37900
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Does this pr and #37743 solve the same issue? |
Contributor
Author
|
ah they fix the same issue. Let me comment on that PR. |
srowen
approved these changes
Sep 17, 2022
beliefer
approved these changes
Sep 19, 2022
Contributor
Author
|
Since #37743 is inactive, I'll merge this PR but assign the JIRA ticket to that PR author to share credits. |
Contributor
Author
|
thanks for review, merging to master! |
LuciferYang
pushed a commit
to LuciferYang/spark
that referenced
this pull request
Sep 20, 2022
…repeatedly ### What changes were proposed in this pull request? This PR caches the result of `PartitionReader.next` in `PartitionIterator`, so that its `hasNext` method is cheap to be called repeatedly. ### Why are the changes needed? potential perf improvement. `PartitionReader.next` can be expensive in some v2 sources, and it's legal to call `Iterator.hasNext` repeatedly. ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? existing tests Closes apache#37900 from cloud-fan/minor. Authored-by: Wenchen Fan <[email protected]> Signed-off-by: Wenchen Fan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR caches the result of
PartitionReader.nextinPartitionIterator, so that itshasNextmethod is cheap to be called repeatedly.Why are the changes needed?
potential perf improvement.
PartitionReader.nextcan be expensive in some v2 sources, and it's legal to callIterator.hasNextrepeatedly.Does this PR introduce any user-facing change?
no
How was this patch tested?
existing tests