Skip to content

[SPARK-44044][SS] Improve Error message for Window functions with streaming #41578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
siying wants to merge 14 commits into from
Closed

[SPARK-44044][SS] Improve Error message for Window functions with streaming #41578

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
e83a54e
[SPARK-44044][SS] Improve Error message for SQL Window functions
siying Jun 13, 2023
fda3dac
test
siying Jun 13, 2023
8f464fb
Address "nit" comments.
siying Jun 14, 2023
ad9c2ce
Include window spec
siying Jun 14, 2023
9e02f32
fix unit test. (Have to change the error message to follow the existi…
siying Jun 15, 2023
c708be1
Address comments
siying Jun 21, 2023
c6be32e
reorder
siying Jun 21, 2023
446c1a3
Address comments.
siying Jun 22, 2023
ae2fe1c
Revert unintended indenting change
siying Jun 27, 2023
e5a52cb
Update core/src/main/resources/error/error-classes.json
siying Jun 28, 2023
fe4060e
Update sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryE…
siying Jun 28, 2023
8f55d96
Address comments
siying Jun 28, 2023
786e32a
Update core/src/main/resources/error/error-classes.json
siying Jun 29, 2023
d70e355
Address comment
siying Jun 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Address "nit" comments.
  • Loading branch information
@siying
siying committed Jun 30, 2023
commit 8f464fb5c504259f6bcff96d85912416289f9465
6 changes: 3 additions & 3 deletions ...t/src/main/scala/org/apache/spark/sql/catalyst/analysis/UnsupportedOperationChecker.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -511,12 +511,12 @@ object UnsupportedOperationChecker extends Logging {
case Window(_, _, _, child) if child.isStreaming =>
val windowFuncs = subPlan.asInstanceOf[Window].windowExpressions.flatMap { e =>
e.collect {
case we: WindowExpression => s"${we.windowFunction} AS ${e.toAttribute.sql}"
case we: WindowExpression => s"${we.windowFunction} as column ${e.toAttribute.sql}"
}
}.mkString(", ")
throw new AnalysisException(
s"Unsupported window function found in column '$windowFuncs'. Structured " +
"streaming only supports time-window aggregation using the `window` function.",
s"Unsupported window function in '$windowFuncs'. Structured " +
"Streaming only supports time-window aggregation using the `window` function.",
subPlan.origin.line,
subPlan.origin.startPosition)

Expand Down