-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-44044][SS] Improve Error message for Window functions with streaming #41578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
e83a54e
[SPARK-44044][SS] Improve Error message for SQL Window functions
siying fda3dac
test
siying 8f464fb
Address "nit" comments.
siying ad9c2ce
Include window spec
siying 9e02f32
fix unit test. (Have to change the error message to follow the existi…
siying c708be1
Address comments
siying c6be32e
reorder
siying 446c1a3
Address comments.
siying ae2fe1c
Revert unintended indenting change
siying e5a52cb
Update core/src/main/resources/error/error-classes.json
siying fe4060e
Update sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryE…
siying 8f55d96
Address comments
siying 786e32a
Update core/src/main/resources/error/error-classes.json
siying d70e355
Address comment
siying File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Include window spec
- Loading branch information
commit ad9c2cecd4233e8ab30041fb5bbfbc99a027b98d
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
case w @ Window(_, _, _, child) if child.isStreaming =>w would be same as
subPlan.asInstanceOf[Window]There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it doesn't even need to... we can just extract the value out from the pattern.
and then remove L512 and use
windowExpressionsdirectly.