Skip to content

Conversation

@HyukjinKwon
Copy link
Member

@HyukjinKwon HyukjinKwon commented Sep 25, 2023

What changes were proposed in this pull request?

In theory, we don't need #29875 anymore because we dropped JDK 8 (according to the PR description in #29875) but Utils.getSimpleClass handles malformed class names in any event, so should be safe to keep them.

Why are the changes needed?

To remove test that does not run. We dropped JDK 11/8 at SPARK-44112

Does this PR introduce any user-facing change?

No, test-only.

How was this patch tested?

CI in this PR should test them out.

Was this patch authored or co-authored using generative AI tooling?

No.

@HyukjinKwon
Copy link
Member Author

cc @rednaxelafx

@github-actions github-actions bot added the SQL label Sep 25, 2023
Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM.

@dongjoon-hyun dongjoon-hyun changed the title [SPARK-45305][TESTS] Remove JDK 8 workaround added TreeNodeSuite [SPARK-45305][SQL][TESTS] Remove JDK 8 workaround added TreeNodeSuite Sep 25, 2023
@dongjoon-hyun
Copy link
Member

I verified manually this removal. This suite works fine without any compilation issue.

$ build/sbt "catalyst/testOnly *.TreeNodeSuite"
...
[info] Run completed in 1 second, 730 milliseconds.
[info] Total number of tests run: 34
[info] Suites: completed 1, aborted 0
[info] Tests: succeeded 34, failed 0, canceled 0, ignored 0, pending 0
[info] All tests passed.
[success] Total time: 10 s, completed Sep 25, 2023, 10:07:21 AM

@dongjoon-hyun
Copy link
Member

Merged to master.

@HyukjinKwon HyukjinKwon deleted the SPARK-45305 branch January 15, 2024 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants