Skip to content

[SPARK-45305][SQL][TESTS] Remove JDK 8 workaround added TreeNodeSuite #43092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
HyukjinKwon wants to merge 2 commits into from
Closed

[SPARK-45305][SQL][TESTS] Remove JDK 8 workaround added TreeNodeSuite #43092

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a91472a
Remove JDK 8 workaround added SPARK-32999
HyukjinKwon Sep 25, 2023
bc83c2f
remove unused object in the class
HyukjinKwon Sep 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 0 additions & 29 deletions sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/trees/TreeNodeSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -864,35 +864,6 @@ class TreeNodeSuite extends SparkFunSuite with SQLHelper {
assert(getStateful(withNestedStatefulBefore) ne getStateful(withNestedStatefulAfter))
}

object MalformedClassObject extends Serializable {
case class MalformedNameExpression(child: Expression) extends TaggingExpression {
override protected def withNewChildInternal(newChild: Expression): Expression =
copy(child = newChild)
}
}

test("SPARK-32999: TreeNode.nodeName should not throw malformed class name error") {
val testTriggersExpectedError = try {
classOf[MalformedClassObject.MalformedNameExpression].getSimpleName
false
} catch {
case ex: java.lang.InternalError if ex.getMessage.contains("Malformed class name") =>
true
case ex: Throwable => throw ex
}
// This test case only applies on older JDK versions (e.g. JDK8u), and doesn't trigger the
// issue on newer JDK versions (e.g. JDK11u).
assume(testTriggersExpectedError, "the test case didn't trigger malformed class name error")

val expr = MalformedClassObject.MalformedNameExpression(Literal(1))
try {
expr.nodeName
} catch {
case ex: java.lang.InternalError if ex.getMessage.contains("Malformed class name") =>
fail("TreeNode.nodeName should not throw malformed class name error")
}
}

test("SPARK-37800: TreeNode.argString incorrectly formats arguments of type Set[_]") {
case class Node(set: Set[String], nested: Seq[Set[Int]]) extends LeafNode {
val output: Seq[Attribute] = Nil
Expand Down