[SPARK-47705][INFRA] Sort LogKey alphabetically and build a test to ensure it #45857
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
gengliangwang
approved these changes
Apr 3, 2024
Member
|
@dtenedor on second thought, could you move the new file under https://github.com/apache/spark/tree/master/common/utils/src/test/scala/org/apache/spark/util ? |
Contributor
Author
👍 @gengliangwang this is done. |
gengliangwang
approved these changes
Apr 3, 2024
Member
|
Verified the new test passes on my local. |
gengliangwang
pushed a commit
that referenced
this pull request
Apr 4, 2024
… test to ensure it ### What changes were proposed in this pull request? The pr aims to fix bug about #45857 ### Why are the changes needed? In fact, `LogKey.values.toSeq.sorted` did not sort alphabetically as expected. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? - Pass GA. - Manually test. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #45864 from panbingkun/fix_sort_logkey. Authored-by: panbingkun <[email protected]> Signed-off-by: Gengliang Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR adds a unit test to ensure that the fields of the
LogKeyenumeration are sorted alphabetically, as specified by https://issues.apache.org/jira/browse/SPARK-47705.Why are the changes needed?
This will make sure that the fields of the enumeration remain easy to read in the future as we add more cases.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
This PR adds testing coverage only.
Was this patch authored or co-authored using generative AI tooling?
GitHub copilot offered some suggestions, but I rejected them