Skip to content

[SPARK-47705][INFRA] Sort LogKey alphabetically and build a test to ensure it #45857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dtenedor wants to merge 2 commits into from
Closed

[SPARK-47705][INFRA] Sort LogKey alphabetically and build a test to ensure it #45857

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
26d965a
commit
dtenedor Apr 3, 2024
b3da695
respond to code review comments
dtenedor Apr 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
respond to code review comments
  • Loading branch information
@dtenedor
dtenedor committed Apr 3, 2024
commit b3da695e016612d32b21f11a6993d2424dc49f48
8 changes: 6 additions & 2 deletions ...a/org/apache/spark/util/LogKeySuite.scala → ...a/org/apache/spark/util/LogKeySuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,14 @@

package org.apache.spark.util

import org.apache.spark.SparkFunSuite
import org.scalatest.funsuite.AnyFunSuite // scalastyle:ignore funsuite

import org.apache.spark.internal.{Logging, LogKey}

class LogKeySuite extends SparkFunSuite with Logging {
class LogKeySuite
extends AnyFunSuite // scalastyle:ignore funsuite
with Logging {

test("LogKey enumeration fields must be sorted alphabetically") {
val keys = LogKey.values.toSeq
assert(keys === keys.sorted, "LogKey enumeration fields must be sorted alphabetically")
Expand Down