[SPARK-48421][SQL] SPJ: Add documentation #46745
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
reviewed
May 27, 2024
HyukjinKwon
approved these changes
Jun 11, 2024
Member
|
But would be great if we have eyes from other folks like @sunchao @cloud-fan |
sunchao
approved these changes
Jun 11, 2024
Member
sunchao
left a comment
sunchao
left a comment
There was a problem hiding this comment.
LGTM too with a few nits, thanks @szehon-ho !
|
|
||
| Storage Partition Join (SPJ) is an optimization technique in Spark SQL that makes use the existing storage layout to avoid the shuffle phase. | ||
|
|
||
| This is a generalization of the concept of Bucket Joins, which is only applicable for [bucketed](sql-data-sources-load-save-functions.html#bucketing-sorting-and-partitioning) tables, to tables partitioned by functions registered in FunctionCatalog. Storage Partition Joins are currently supported for compatible V2 DataSources. |
Member
There was a problem hiding this comment.
nit: this bucketed link doesn't work
Member
Author
There was a problem hiding this comment.
Hm, i built the site and it seems to work, but let me know if another one is better here?
docs/sql-performance-tuning.md
Outdated
|
|
||
| This is a generalization of the concept of Bucket Joins, which is only applicable for [bucketed](sql-data-sources-load-save-functions.html#bucketing-sorting-and-partitioning) tables, to tables partitioned by functions registered in FunctionCatalog. Storage Partition Joins are currently supported for compatible V2 DataSources. | ||
|
|
||
| The following SQL properties enable Storage Partition Join. |
Member
There was a problem hiding this comment.
nit: perhaps The following SQL properties enable Storage Partition Join and various optimizations of it?
Member
Author
There was a problem hiding this comment.
done, added 'in different join queries with various optimizations.' (as some flags are about different scenarios)
Member
|
Merged to master. |
Member
Author
|
Thank you @HyukjinKwon @sunchao |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add docs for SPJ
Why are the changes needed?
There are no docs describing SPJ, even though it is mentioned in migration notes: #46673
Does this PR introduce any user-facing change?
No
How was this patch tested?
Checked the new text
Was this patch authored or co-authored using generative AI tooling?
No