Skip to content

[SPARK-48627][SQL] Perf improvement for binary to to HEX_DISCRETE string #46984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yaooqinn wants to merge 2 commits into from
Closed

[SPARK-48627][SQL] Perf improvement for binary to to HEX_DISCRETE string #46984

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d1f357c
[SPARK-48627][SQL] Perf improvement for binary to to HEX_DISCRETE string
yaooqinn Jun 14, 2024
6eac45f
[SPARK-48627][SQL] Perf improvement for binary to to HEX_DISCRETE string
yaooqinn Jun 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion sql/api/src/main/scala/org/apache/spark/sql/catalyst/util/StringUtils.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
*/
package org.apache.spark.sql.catalyst.util

import java.util.HexFormat
import java.util.concurrent.atomic.AtomicBoolean

import org.apache.spark.internal.Logging
Expand Down Expand Up @@ -101,11 +102,16 @@ object SparkStringUtils extends Logging {
truncatedString(seq, "", sep, "", maxFields)
}

private final lazy val SPACE_DELIMITED_UPPERCASE_HEX =
HexFormat.of().withDelimiter(" ").withUpperCase()

/**
* Returns a pretty string of the byte array which prints each byte as a hex digit and add spaces
* between them. For example, [1A C0].
*/
def getHexString(bytes: Array[Byte]): String = bytes.map("%02X".format(_)).mkString("[", " ", "]")
def getHexString(bytes: Array[Byte]): String = {
s"[${SPACE_DELIMITED_UPPERCASE_HEX.formatHex(bytes)}]"
}

def sideBySide(left: String, right: String): Seq[String] = {
sideBySide(left.split("\n").toImmutableArraySeq, right.split("\n").toImmutableArraySeq)
Expand Down
6 changes: 0 additions & 6 deletions sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/StringUtils.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,12 +66,6 @@ object StringUtils extends Logging {
"(?s)" + out.result() // (?s) enables dotall mode, causing "." to match new lines
}

/**
Copy link
Contributor

@LuciferYang LuciferYang Jun 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the function that should be deleted in #42184?

Copy link
Member Author

@yaooqinn yaooqinn Jun 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I can not answer your question since I wasn't there.

Copy link
Contributor

@LuciferYang LuciferYang Jun 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

both org.apache.spark.sql.catalyst.util.StringUtils and getHexString are public, should we keep them?

Copy link
Member Author

@yaooqinn yaooqinn Jun 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The catalyst package is private by contract

* Returns a pretty string of the byte array which prints each byte as a hex digit and add spaces
* between them. For example, [1A C0].
*/
def getHexString(bytes: Array[Byte]): String = bytes.map("%02X".format(_)).mkString("[", " ", "]")

private[this] val trueStrings =
Set("t", "true", "y", "yes", "1").map(UTF8String.fromString)

Expand Down