[SPARK-48704][INFRA] Update build_sparkr_window.yml to use windows-2022
#47076
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Let me test it based on the |
HyukjinKwon
reviewed
Jun 25, 2024
| # under the License. | ||
| # | ||
| name: "Build / SparkR-only (master, 4.4.0, windows-2019)" | ||
| name: "Build / SparkR-only (master, 4.4.0, windows-2022)" |
Member
There was a problem hiding this comment.
It actually fails some tests so I used 2019 :-). It would need more fixes
Contributor
Author
There was a problem hiding this comment.
Thanks, okay, Let me investigate it carefully. 😄
Contributor
Author
There was a problem hiding this comment.
However, the test based on windows server 2022 surprisingly succeeded, which is amazing.
#47021
https://github.com/panbingkun/spark/actions/runs/9655626675/job/26631829756
Contributor
Author
There was a problem hiding this comment.
Haha, let's continue to observe the scheduling of build_sparkr_window.yml every day. ❤️
HyukjinKwon
approved these changes
Jun 25, 2024
Member
|
Merged to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The pr aims to update
build_sparkr_window.ymlto usewindows-2022(fromwindows-2019)Why are the changes needed?
windows-latestnow points towindows-2022.Because
windows-2019has already exceededMainstream End Date(Jan 9, 2024).https://github.com/actions/runner-images?tab=readme-ov-file#available-images
windows-server-2019
https://learn.microsoft.com/en-us/lifecycle/products/windows-server-2019
windows-server-2022
https://learn.microsoft.com/en-us/lifecycle/products/windows-server-2022
Mainstream End Date&Extended End DateMainstream End Date: Date the product ceases to receive enhancements or new features.
Extended End Date: After this date, these products will no longer receive security updates, non-security updates, bug fixes, technical support or online technical content updates.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass GA.
Was this patch authored or co-authored using generative AI tooling?
No.