Skip to content

[SPARK-48704][INFRA] Update build_sparkr_window.yml to use windows-2022 #47076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
panbingkun wants to merge 1 commit into from
Closed

[SPARK-48704][INFRA] Update build_sparkr_window.yml to use windows-2022 #47076

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/build_sparkr_window.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
# specific language governing permissions and limitations
# under the License.
#
name: "Build / SparkR-only (master, 4.4.0, windows-2019)"
name: "Build / SparkR-only (master, 4.4.0, windows-2022)"
Copy link
Member

@HyukjinKwon HyukjinKwon Jun 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It actually fails some tests so I used 2019 :-). It would need more fixes

Copy link
Contributor Author

@panbingkun panbingkun Jun 25, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, okay, Let me investigate it carefully. 😄

Copy link
Contributor Author

@panbingkun panbingkun Jun 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

However, the test based on windows server 2022 surprisingly succeeded, which is amazing.
#47021
https://github.com/panbingkun/spark/actions/runs/9655626675/job/26631829756
image

Copy link
Member

@HyukjinKwon HyukjinKwon Jun 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good good

Copy link
Contributor Author

@panbingkun panbingkun Jun 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha, let's continue to observe the scheduling of build_sparkr_window.yml every day. ❤️


on:
schedule:
Expand All @@ -25,7 +25,7 @@ on:
jobs:
build:
name: "Build module: sparkr"
runs-on: windows-2019
runs-on: windows-2022
timeout-minutes: 300
if: github.repository == 'apache/spark'
steps:
Expand Down