-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-49057][SQL][TESTS][FOLLOWUP] Handle _LEGACY_ERROR_TEMP_2235 error case
#48498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
_LEGACY_ERROR_TEMP_2235 case
_LEGACY_ERROR_TEMP_2235 case_LEGACY_ERROR_TEMP_2235 case
|
cc @cloud-fan , @ulysses-you , @yaooqinn , @LuciferYang from #47533 |
_LEGACY_ERROR_TEMP_2235 case_LEGACY_ERROR_TEMP_2235 error case
LuciferYang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, LGTM
| } | ||
| assert(error.getMessage() contains "coalesce test error") | ||
| assert(error.getMessage().contains("coalesce test error") || | ||
| error.getMessage().contains("Multiple failures in stage materialization")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For Multiple failures in stage materialization, we put each stage's failure into Exception#suppressed. Shall we find the coalesce test error in the suppressed errors?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, @cloud-fan .
|
Thank you, @LuciferYang and @cloud-fan . Could you review once more? I addressed all comments. |
|
Could you review this too, @viirya ? This is a little very flaky in these days in CIs. Multiple times a day. |
|
Thank you, @LuciferYang , @cloud-fan , @viirya . Let me merge this to stabilize our CIs. |
|
late lgtm! |
What changes were proposed in this pull request?
This PR aims to fix a flaky test by handling
_LEGACY_ERROR_TEMP_2235(multiple failures exception) in addition to the single exception.Why are the changes needed?
After merging
The following failures were reported multiple times in the PR and today.
The root cause is that
AdaptiveSparkPlanExec.cleanUpAndThrowExceptionthrows two types of exceptions. When there are multiple errors,_LEGACY_ERROR_TEMP_2235is thrown. We need to handle this too in the test case.spark/sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/AdaptiveSparkPlanExec.scala
Lines 843 to 850 in bcfe62b
spark/sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryExecutionErrors.scala
Lines 1916 to 1921 in bcfe62b
Does this PR introduce any user-facing change?
No, this is a test-only change.
How was this patch tested?
Pass the CIs.
Was this patch authored or co-authored using generative AI tooling?
No.