Skip to content

[SPARK-49057][SQL][TESTS][FOLLOWUP] Handle _LEGACY_ERROR_TEMP_2235 error case #48498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dongjoon-hyun wants to merge 2 commits into from
Closed

[SPARK-49057][SQL][TESTS][FOLLOWUP] Handle _LEGACY_ERROR_TEMP_2235 error case #48498

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dba7539
[SPARK-49057][SQL][FOLLOWUP] Handle _LEGACY_ERROR_TEMP_2235 case
dongjoon-hyun Oct 16, 2024
5c4733c
Address comments
dongjoon-hyun Oct 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
[SPARK-49057][SQL][FOLLOWUP] Handle _LEGACY_ERROR_TEMP_2235 case
  • Loading branch information
@dongjoon-hyun
dongjoon-hyun committed Oct 16, 2024
commit dba753990bd4245a0646cfa53722fa8152fa3795
3 changes: 2 additions & 1 deletion sql/core/src/test/scala/org/apache/spark/sql/execution/adaptive/AdaptiveQueryExecSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -936,7 +936,8 @@ class AdaptiveQueryExecSuite
val error = intercept[SparkException] {
joined.collect()
}
assert(error.getMessage() contains "coalesce test error")
assert(error.getMessage().contains("coalesce test error") ||
error.getMessage().contains("Multiple failures in stage materialization"))
Copy link
Contributor

@cloud-fan cloud-fan Oct 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For Multiple failures in stage materialization, we put each stage's failure into Exception#suppressed. Shall we find the coalesce test error in the suppressed errors?

Copy link
Member Author

@dongjoon-hyun dongjoon-hyun Oct 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, @cloud-fan .


val adaptivePlan = joined.queryExecution.executedPlan.asInstanceOf[AdaptiveSparkPlanExec]

Expand Down