[SPARK-47081][CONNECT][FOLLOW-UP] Respect spark.connect.progress.reportInterval over timeout
#49474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloud-fan
approved these changes
Jan 14, 2025
Member
Author
|
Merged to master. |
HyukjinKwon
added a commit
that referenced
this pull request
Jan 14, 2025
…rtInterval over timeout ### What changes were proposed in this pull request? This PR is a followup of #49474 that properly assigns the value to `timeout`. ### Why are the changes needed? It was a mistake that did not assign the value back. ### Does this PR introduce _any_ user-facing change? Yes, same as #49474 ### How was this patch tested? Manually. ### Was this patch authored or co-authored using generative AI tooling? No Closes #49484 from HyukjinKwon/SPARK-47081-followup4. Authored-by: Hyukjin Kwon <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR is a followup that addresses #45150 (comment)
Why are the changes needed?
To respect
spark.connect.progress.reportIntervalDoes this PR introduce any user-facing change?
Virtually no. In corner case, it the progress upgrade might take longer than
spark.connect.progress.reportInterval.How was this patch tested?
Manually tested.
Was this patch authored or co-authored using generative AI tooling?
No.