Skip to content

[SPARK-7437][SQL] Fold "literal in (item1, item2, ..., literal, ...)" into true or false directly #5972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pzzs wants to merge 21 commits into from
Closed

[SPARK-7437][SQL] Fold "literal in (item1, item2, ..., literal, ...)" into true or false directly #5972

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
c3f046f
Merge pull request #1 from apache/master
pzzs Mar 2, 2015
cb1852d
Merge pull request #2 from apache/master
pzzs Mar 5, 2015
c87e8b6
Merge pull request #3 from apache/master
pzzs Mar 10, 2015
161cae3
Merge pull request #4 from apache/master
pzzs Mar 12, 2015
98b134f
Merge pull request #5 from apache/master
pzzs Mar 19, 2015
d00303b
Merge pull request #6 from apache/master
pzzs Mar 24, 2015
802261c
Merge pull request #7 from apache/master
pzzs Mar 26, 2015
34b1a9a
Merge pull request #8 from apache/master
pzzs Apr 8, 2015
f61210c
Merge pull request #9 from apache/master
pzzs Apr 17, 2015
f12fa50
Merge pull request #10 from apache/master
pzzs Apr 21, 2015
f03fe7f
Merge pull request #12 from apache/master
pzzs Apr 29, 2015
14952e2
Merge pull request #13 from apache/master
pzzs May 7, 2015
2e8f6ca
Update Optimizer.scala
pzzs May 7, 2015
36c194e
Update Optimizer.scala
pzzs May 7, 2015
35ceb7a
Update Optimizer.scala
pzzs May 7, 2015
f4dbf50
Update ConstantFoldingSuite.scala
pzzs May 7, 2015
24739bd
Update ConstantFoldingSuite.scala
pzzs May 7, 2015
e34c28a
Update predicates.scala
pzzs May 8, 2015
fa461a5
Update Optimizer.scala
pzzs May 8, 2015
abe2bbb
Update Optimizer.scala
pzzs May 8, 2015
4c722a2
Update predicates.scala
pzzs May 8, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update Optimizer.scala
  • Loading branch information
@pzzs
pzzs committed May 7, 2015
commit 36c194e9d37f91b6e8696d76dc759de7c95eae44
10 changes: 4 additions & 6 deletions sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,12 +294,10 @@ object ConstantFolding extends Rule[LogicalPlan] {
case e if e.foldable => Literal.create(e.eval(null), e.dataType)
Copy link
Contributor

@rxin rxin May 7, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this not folded by this case?

Copy link
Contributor

@marmbrus marmbrus May 7, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, the real bug is that InSet does not correctly implement foldable.

Copy link
Contributor Author

@pzzs pzzs May 8, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this proposal is very smart!!


// Fold "literal in (item1, item2, ..., literal, ...)" into true or false directly.
case In(Literal(v, _), list) =>
val isExists = list.exists {
case Literal(candidate, _) if candidate == v => true
case _ => false
}
if (isExists) Literal.create(true, BooleanType) else Literal.create(false, BooleanType)
case InSet(Literal(v, _), hSet) => {
val isExists = hSet.contains(v)
if(isExists) Literal.create(true, BooleanType) else Literal.create(false, BooleanType)
}
}
}
}
Expand Down