-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-7437][SQL] Fold "literal in (item1, item2, ..., literal, ...)" into true or false directly #5972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
+36
−2
Closed
[SPARK-7437][SQL] Fold "literal in (item1, item2, ..., literal, ...)" into true or false directly #5972
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
c3f046f
Merge pull request #1 from apache/master
pzzs cb1852d
Merge pull request #2 from apache/master
pzzs c87e8b6
Merge pull request #3 from apache/master
pzzs 161cae3
Merge pull request #4 from apache/master
pzzs 98b134f
Merge pull request #5 from apache/master
pzzs d00303b
Merge pull request #6 from apache/master
pzzs 802261c
Merge pull request #7 from apache/master
pzzs 34b1a9a
Merge pull request #8 from apache/master
pzzs f61210c
Merge pull request #9 from apache/master
pzzs f12fa50
Merge pull request #10 from apache/master
pzzs f03fe7f
Merge pull request #12 from apache/master
pzzs 14952e2
Merge pull request #13 from apache/master
pzzs 2e8f6ca
Update Optimizer.scala
pzzs 36c194e
Update Optimizer.scala
pzzs 35ceb7a
Update Optimizer.scala
pzzs f4dbf50
Update ConstantFoldingSuite.scala
pzzs 24739bd
Update ConstantFoldingSuite.scala
pzzs e34c28a
Update predicates.scala
pzzs fa461a5
Update Optimizer.scala
pzzs abe2bbb
Update Optimizer.scala
pzzs 4c722a2
Update predicates.scala
pzzs File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Update Optimizer.scala
- Loading branch information
commit fa461a5469721e3704a27df833a3a85d45b450b0
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this not folded by this case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, the real bug is that
InSetdoes not correctly implementfoldable.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this proposal is very smart!!