Skip to content
118 changes: 118 additions & 0 deletions mllib/src/main/scala/org/apache/spark/ml/feature/Bucketizer.scala
Original file line number Diff line number Diff line change
@@ -0,0 +1,118 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

package org.apache.spark.ml.feature

import org.apache.spark.annotation.AlphaComponent
import org.apache.spark.ml.attribute.NominalAttribute
import org.apache.spark.ml.param._
import org.apache.spark.ml.param.shared.{HasInputCol, HasOutputCol}
import org.apache.spark.ml.util.SchemaUtils
import org.apache.spark.ml.{Estimator, Model}
import org.apache.spark.sql._
import org.apache.spark.sql.functions._
import org.apache.spark.sql.types.{DoubleType, StructType}

/**
* :: AlphaComponent ::
* `Bucketizer` maps a column of continuous features to a column of feature buckets.
*/
@AlphaComponent
final class Bucketizer(override val parent: Estimator[Bucketizer] = null)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should use 2 constructors (1 with an argument, 1 without) to be Java-friendly. Also, can we make the constructor with 1 argument be private[ml] for now?

extends Model[Bucketizer] with HasInputCol with HasOutputCol {

/**
* The given buckets should match 1) its size is larger than zero; 2) it is ordered in a non-DESC
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strictly increasing

* way.
*/
private def checkBuckets(buckets: Array[Double]): Boolean = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be static?

if (buckets.size == 0) false
else if (buckets.size == 1) true
else {
buckets.foldLeft((true, Double.MinValue)) { case ((validator, prevValue), currValue) =>
if (validator & prevValue <= currValue) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use &&? Use < (strictly increasing)

(true, currValue)
} else {
(false, currValue)
}
}._1
}
}

/**
* Parameter for mapping continuous features into buckets.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be named "splits" instead of "buckets".
Here and in parameter doc, we should specify how bucketing is done precisely:
With n splits, there are n+1 buckets. A bucket defined by splits x,y holds values in the range [x,y).

* @group param
*/
val buckets: Param[Array[Double]] = new Param[Array[Double]](this, "buckets",
"Split points for mapping continuous features into buckets.", checkBuckets)

/** @group getParam */
def getBuckets: Array[Double] = $(buckets)

/** @group setParam */
def setBuckets(value: Array[Double]): this.type = set(buckets, value)

/** @group setParam */
def setInputCol(value: String): this.type = set(inputCol, value)

/** @group setParam */
def setOutputCol(value: String): this.type = set(outputCol, value)

override def transform(dataset: DataFrame): DataFrame = {
transformSchema(dataset.schema)
val bucketizer = udf { feature: Double => binarySearchForBuckets($(buckets), feature) }
val outputColName = $(outputCol)
val metadata = NominalAttribute.defaultAttr
.withName(outputColName).withValues($(buckets).map(_.toString)).toMetadata()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The values look incorrect since there should be n+1 buckets given n splits. Also, can you please reuse the code for metadata construction here and in transformSchema?

dataset.select(col("*"), bucketizer(dataset($(inputCol))).as(outputColName, metadata))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine, but it can be a little simpler to use dataset.withColumn (See for example, VectorIndexer) instead of "select."

}

/**
* Binary searching in several buckets to place each data point.
*/
private def binarySearchForBuckets(splits: Array[Double], feature: Double): Double = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to make this private[feature] to allow a unit test of this method. Could you please add a test? Also, should this method be static?

val wrappedSplits = Array(Double.MinValue) ++ splits ++ Array(Double.MaxValue)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be constructed beforehand, rather than constructing it every time the UDF is called.

var left = 0
var right = wrappedSplits.length - 2
while (left <= right) {
val mid = left + (right - left) / 2
val split = wrappedSplits(mid)
if ((feature > split) && (feature <= wrappedSplits(mid + 1))) {
return mid
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not convinced this works for all cases. Could you please add a few more unit tests to check boundary conditions? I'm imagining a test with a small vector which tests:

  • each side being with and without inclusive
  • values outside splits, between splits, and at splits (to make sure the split boundaries are documented correctly above)

} else if (feature <= split) {
right = mid - 1
} else {
left = mid + 1
}
}
-1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should throw an exception if it gets to here.

}

override def transformSchema(schema: StructType): StructType = {
SchemaUtils.checkColumnType(schema, $(inputCol), DoubleType)

val inputFields = schema.fields
val outputColName = $(outputCol)

require(inputFields.forall(_.name != outputColName),
s"Output column $outputColName already exists.")

val attr = NominalAttribute.defaultAttr.withName(outputColName)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please set the fields "values" and "isOrdinal" as well?

val outputFields = inputFields :+ attr.toStructField()
StructType(outputFields)
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

package org.apache.spark.ml.feature

import org.apache.spark.mllib.util.MLlibTestSparkContext
import org.apache.spark.sql.{DataFrame, Row, SQLContext}
import org.scalatest.FunSuite
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

organize imports: non-spark ones should precede spark ones, with a newline in between


class BucketizerSuite extends FunSuite with MLlibTestSparkContext {

test("Bucket continuous features with setter") {
val sqlContext = new SQLContext(sc)
val data = Array(0.1, -0.5, 0.2, -0.3, 0.8, 0.7, -0.1, -0.4)
val buckets = Array(-0.5, 0.0, 0.5)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename to "splits"

val bucketizedData = Array(2.0, 0.0, 2.0, 1.0, 3.0, 3.0, 1.0, 1.0)
val dataFrame: DataFrame = sqlContext.createDataFrame(
data.zip(bucketizedData)).toDF("feature", "expected")

val bucketizer: Bucketizer = new Bucketizer()
.setInputCol("feature")
.setOutputCol("result")
.setBuckets(buckets)

bucketizer.transform(dataFrame).select("result", "expected").collect().foreach {
case Row(x: Double, y: Double) =>
assert(x === y, "The feature value is not correct after bucketing.")
}
}
}