[SPARK-10102][Streaming]Fix a race condition that startReceiver may happen before setting trackerState to Started #8294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ckerState to Started
Member
Author
|
BTW, other usages of |
zsxwing
changed the title
Member
Author
|
Fired a new JIRA since this is a bug in the main codes. |
Contributor
There was a problem hiding this comment.
Can you make this a internal function? def shouldStartReceiver: Boolean = !(isTrackerStopping || isTrackerStopped)
and then use if (!shouldStartReceiver) { ... }
Contributor
There was a problem hiding this comment.
And add comments that its okay to start when the state = initialized / started
Contributor
|
LGTM. Will merge when tests pass. |
|
Test build #41196 has finished for PR 8294 at commit
|
Contributor
|
Merging this to master and 1.5, thanks @zsxwing for finding this issue. |
asfgit
pushed a commit
that referenced
this pull request
Aug 19, 2015
… happen before setting trackerState to Started Test failure: https://amplab.cs.berkeley.edu/jenkins/job/Spark-Master-Maven-with-YARN/HADOOP_PROFILE=hadoop-2.4,label=spark-test/3305/testReport/junit/org.apache.spark.streaming/StreamingContextSuite/stop_gracefully/ There is a race condition that setting `trackerState` to `Started` could happen after calling `startReceiver`. Then `startReceiver` won't start the receivers because it uses `! isTrackerStarted` to check if ReceiverTracker is stopping or stopped. But actually, `trackerState` is `Initialized` and will be changed to `Started` soon. Therefore, we should use `isTrackerStopping || isTrackerStopped`. Author: zsxwing <[email protected]> Closes #8294 from zsxwing/SPARK-9504. (cherry picked from commit 90273ef) Signed-off-by: Tathagata Das <[email protected]>
|
Test build #41191 timed out for PR 8294 at commit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test failure: https://amplab.cs.berkeley.edu/jenkins/job/Spark-Master-Maven-with-YARN/HADOOP_PROFILE=hadoop-2.4,label=spark-test/3305/testReport/junit/org.apache.spark.streaming/StreamingContextSuite/stop_gracefully/
There is a race condition that setting
trackerStatetoStartedcould happen after callingstartReceiver. ThenstartReceiverwon't start the receivers because it uses! isTrackerStartedto check if ReceiverTracker is stopping or stopped. But actually,trackerStateisInitializedand will be changed toStartedsoon.Therefore, we should use
isTrackerStopping || isTrackerStopped.