Skip to content

[SPARK-10102][Streaming]Fix a race condition that startReceiver may happen before setting trackerState to Started #8294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zsxwing wants to merge 2 commits into from
Closed

[SPARK-10102][Streaming]Fix a race condition that startReceiver may happen before setting trackerState to Started #8294

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c1a6126
Fix a race condition that startReceiver may happen before setting tra…
zsxwing Aug 19, 2015
36e7836
Add shouldStartReceiver
zsxwing Aug 19, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions streaming/src/main/scala/org/apache/spark/streaming/scheduler/ReceiverTracker.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -469,7 +469,7 @@ class ReceiverTracker(ssc: StreamingContext, skipReceiverLaunch: Boolean = false
*/
private def startReceiver(receiver: Receiver[_], scheduledExecutors: Seq[String]): Unit = {
val receiverId = receiver.streamId
if (!isTrackerStarted) {
if (isTrackerStopping || isTrackerStopped) {
Copy link
Contributor

@tdas tdas Aug 19, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make this a internal function? def shouldStartReceiver: Boolean = !(isTrackerStopping || isTrackerStopped)
and then use if (!shouldStartReceiver) { ... }

Copy link
Contributor

@tdas tdas Aug 19, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And add comments that its okay to start when the state = initialized / started

onReceiverJobFinish(receiverId)
return
}
Expand All @@ -494,14 +494,14 @@ class ReceiverTracker(ssc: StreamingContext, skipReceiverLaunch: Boolean = false
// We will keep restarting the receiver job until ReceiverTracker is stopped
future.onComplete {
case Success(_) =>
if (!isTrackerStarted) {
if (isTrackerStopping || isTrackerStopped) {
onReceiverJobFinish(receiverId)
} else {
logInfo(s"Restarting Receiver $receiverId")
self.send(RestartReceiver(receiver))
}
case Failure(e) =>
if (!isTrackerStarted) {
if (isTrackerStopping || isTrackerStopped) {
onReceiverJobFinish(receiverId)
} else {
logError("Receiver has been stopped. Try to restart it.", e)
Expand Down