Skip to content

Conversation

@jkbradley
Copy link
Member

For each (document, term) pair, return top topic. Note that instances of (doc, term) pairs within a document (a.k.a. "tokens") are exchangeable, so we should provide an estimate per document-term, rather than per token.

CC: @rotationsymmetry @mengxr

@SparkQA
Copy link

SparkQA commented Aug 20, 2015

Test build #41302 has finished for PR 8329 at commit bac12ec.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@jkbradley
Copy link
Member Author

did not actually fail

@jkbradley
Copy link
Member Author

test this please

@SparkQA
Copy link

SparkQA commented Aug 20, 2015

Test build #41304 has finished for PR 8329 at commit bac12ec.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix indentation

@mengxr
Copy link
Contributor

mengxr commented Aug 20, 2015

LGTM except two minor comments.

@jkbradley
Copy link
Member Author

OK, updated! I created a temp val for the first comment since, otherwise, it was hard to get the indentation to behave nicely.

@rotationsymmetry
Copy link
Contributor

LGTM.

@SparkQA
Copy link

SparkQA commented Aug 20, 2015

Test build #41332 has finished for PR 8329 at commit eed83b1.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@mengxr
Copy link
Contributor

mengxr commented Aug 20, 2015

Merged into master and branch-1.5. Thanks!

@asfgit asfgit closed this in eaafe13 Aug 20, 2015
asfgit pushed a commit that referenced this pull request Aug 20, 2015
For each (document, term) pair, return top topic.  Note that instances of (doc, term) pairs within a document (a.k.a. "tokens") are exchangeable, so we should provide an estimate per document-term, rather than per token.

CC: rotationsymmetry mengxr

Author: Joseph K. Bradley <[email protected]>

Closes #8329 from jkbradley/lda-topic-assignments.

(cherry picked from commit eaafe13)
Signed-off-by: Xiangrui Meng <[email protected]>
@jkbradley jkbradley deleted the lda-topic-assignments branch August 20, 2015 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants