Skip to content

[SPARK-9245] [MLLIB] LDA topic assignments #8329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jkbradley wants to merge 4 commits into from
Closed

[SPARK-9245] [MLLIB] LDA topic assignments #8329

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d99d5be
updates
jkbradley Aug 19, 2015
58a9e9d
done with topTopicAssignments
jkbradley Aug 20, 2015
bac12ec
added java api
jkbradley Aug 20, 2015
eed83b1
small cleanup
jkbradley Aug 20, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
small cleanup
  • Loading branch information
@jkbradley
jkbradley committed Aug 20, 2015
commit eed83b1b07f526eea8d70db7b19b615ce83a448a
6 changes: 4 additions & 2 deletions mllib/src/main/scala/org/apache/spark/mllib/clustering/LDAModel.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -605,8 +605,10 @@ class DistributedLDAModel private[clustering] (
(terms_topics0._1 ++ terms_topics1._1, terms_topics0._2 ++ terms_topics1._2)
}
// M-STEP: Aggregation computes new N_{kj}, N_{wk} counts.
graph.aggregateMessages[(Array[Int], Array[Int])](sendMsg, mergeMsg).filter(isDocumentVertex)
.map { case (docID: Long, (terms: Array[Int], topics: Array[Int])) =>
val perDocAssignments =
graph.aggregateMessages[(Array[Int], Array[Int])](sendMsg, mergeMsg).filter(isDocumentVertex)
perDocAssignments.map { case (docID: Long, (terms: Array[Int], topics: Array[Int])) =>
// TODO: Avoid zip, which is inefficient.
val (sortedTerms, sortedTopics) = terms.zip(topics).sortBy(_._1).unzip
Copy link
Contributor

@mengxr mengxr Aug 20, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leave a TODO because zip is not efficient

(docID, sortedTerms.toArray, sortedTopics.toArray)
}
Expand Down