Skip to content

[SPARK-10827] [CORE] AppClient should not use askWithReply in receiveAndReply #9317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BryanCutler wants to merge 10 commits into from
+238 −4
Closed

[SPARK-10827] [CORE] AppClient should not use askWithReply in receiveAndReply #9317

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
3872cc6
[SPARK-10827] Changed AppClient receiveAndReply to non-blocking using…
BryanCutler Oct 23, 2015
80794e8
[SPARK-10827] Added unit tests for AppClient
BryanCutler Oct 27, 2015
e33c2b4
Merge remote-tracking branch 'upstream/master' into appClient-receive…
BryanCutler Oct 27, 2015
5e155cc
[SPARK-10827] Used variable to clarify what result the test case is c…
BryanCutler Oct 28, 2015
67bfd2a
[SPARK-10827] Moved receive and reply execution to helper function to…
BryanCutler Oct 30, 2015
ab3e929
Merge remote-tracking branch 'upstream/master' into appClient-receive…
BryanCutler Oct 31, 2015
95d2499
Merge remote-tracking branch 'upstream/master' into appClient-receive…
BryanCutler Nov 2, 2015
3ae1151
Fixed indentation, imports, and spacing
BryanCutler Nov 3, 2015
cd5329c
Fixed threading issues, cleanup, added comments
BryanCutler Nov 4, 2015
4f46cfd
Corrected grammar typo
BryanCutler Nov 4, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Corrected grammar typo
  • Loading branch information
@BryanCutler
BryanCutler committed Nov 4, 2015
commit 4f46cfd093b7de6f811b0fb9891a02ebf5d14293
2 changes: 1 addition & 1 deletion core/src/main/scala/org/apache/spark/deploy/client/AppClient.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,7 @@ private[spark] class AppClient(
context: RpcCallContext,
msg: T): Unit = {
// Create a thread to ask a message and reply with the result. Allow thread to be
// interrupted during shutdown, otherwise context must notified of NonFatal errors.
// interrupted during shutdown, otherwise context must be notified of NonFatal errors.
askAndReplyThreadPool.execute(new Runnable {
override def run(): Unit = {
try {
Expand Down