Skip to content

[SPARK-10827] [CORE] AppClient should not use askWithReply in receiveAndReply #9317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BryanCutler wants to merge 10 commits into from
Closed

[SPARK-10827] [CORE] AppClient should not use askWithReply in receiveAndReply #9317

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
3872cc6
[SPARK-10827] Changed AppClient receiveAndReply to non-blocking using…
BryanCutler Oct 23, 2015
80794e8
[SPARK-10827] Added unit tests for AppClient
BryanCutler Oct 27, 2015
e33c2b4
Merge remote-tracking branch 'upstream/master' into appClient-receive…
BryanCutler Oct 27, 2015
5e155cc
[SPARK-10827] Used variable to clarify what result the test case is c…
BryanCutler Oct 28, 2015
67bfd2a
[SPARK-10827] Moved receive and reply execution to helper function to…
BryanCutler Oct 30, 2015
ab3e929
Merge remote-tracking branch 'upstream/master' into appClient-receive…
BryanCutler Oct 31, 2015
95d2499
Merge remote-tracking branch 'upstream/master' into appClient-receive…
BryanCutler Nov 2, 2015
3ae1151
Fixed indentation, imports, and spacing
BryanCutler Nov 3, 2015
cd5329c
Fixed threading issues, cleanup, added comments
BryanCutler Nov 4, 2015
4f46cfd
Corrected grammar typo
BryanCutler Nov 4, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[SPARK-10827] Used variable to clarify what result the test case is c… 
…hecking
  • Loading branch information
@BryanCutler
BryanCutler committed Oct 28, 2015
commit 5e155cc2f43d98f365524ec6bac81bb6206a780e
5 changes: 3 additions & 2 deletions core/src/test/scala/org/apache/spark/deploy/client/AppClientSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,11 +90,12 @@ class AppClientSuite
}

// Send message to Master to request Executors, verify request by change in executor limit
assert( ci.client.requestTotalExecutors(1) )
val numExecutorsRequested = 1
assert( ci.client.requestTotalExecutors(numExecutorsRequested) )
Copy link
Member

@zsxwing zsxwing Nov 3, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: redundant space


eventually(timeout(10.seconds), interval(10.millis)) {
val apps = getApplications()
assert(apps.head.getExecutorLimit === 1, s"executor total request failed")
assert(apps.head.getExecutorLimit === numExecutorsRequested, s"executor request failed")
}

// Send request to kill executor, verify request was made
Expand Down