[SPARK-1995][SQL] system function upper and lower can be supported #936
+70
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
Contributor
There was a problem hiding this comment.
converted seems better than beConverted here.
Contributor
|
LGTM except some minor formatting issues. |
Contributor
|
Thanks for doing this! We should add this to the hive parser as well. |
Contributor
There was a problem hiding this comment.
Perhaps, "A function that converts the characters of a string to uppercase."
Contributor
Author
|
thanks @liancheng and @marmbrus, I have modified the formatting issues and "nullable". |
Contributor
Author
|
hi @liancheng, @marmbrus, in HiveQl.scala, MAX and MIN is not in it, maybe aggregation function max and min were supported afterwards. |
Contributor
|
test this please |
|
Merged build triggered. |
|
Merged build started. |
Contributor
|
Change the PR title to begin with [SPARK-1995][SQL] ... please |
|
Merged build finished. All automated tests passed. |
|
All automated tests passed. |
egraldlo
changed the title
Contributor
|
Thanks for doing this! Merged in master and 1.0 |
asfgit
pushed a commit
that referenced
this pull request
Jun 3, 2014
I don't know whether it's time to implement system function about string operation in spark sql now. Author: egraldlo <[email protected]> Closes #936 from egraldlo/stringoperator and squashes the following commits: 3c6c60a [egraldlo] Add UPPER, LOWER, MAX and MIN into hive parser ea76d0a [egraldlo] modify the formatting issues b49f25e [egraldlo] modify the formatting issues 1f0bbb5 [egraldlo] system function upper and lower supported 13d3267 [egraldlo] system function upper and lower supported (cherry picked from commit ec8be27) Signed-off-by: Michael Armbrust <[email protected]>
pdeyhim
pushed a commit
to pdeyhim/spark-1
that referenced
this pull request
Jun 25, 2014
I don't know whether it's time to implement system function about string operation in spark sql now. Author: egraldlo <[email protected]> Closes apache#936 from egraldlo/stringoperator and squashes the following commits: 3c6c60a [egraldlo] Add UPPER, LOWER, MAX and MIN into hive parser ea76d0a [egraldlo] modify the formatting issues b49f25e [egraldlo] modify the formatting issues 1f0bbb5 [egraldlo] system function upper and lower supported 13d3267 [egraldlo] system function upper and lower supported
xiliu82
pushed a commit
to xiliu82/spark
that referenced
this pull request
Sep 4, 2014
I don't know whether it's time to implement system function about string operation in spark sql now. Author: egraldlo <[email protected]> Closes apache#936 from egraldlo/stringoperator and squashes the following commits: 3c6c60a [egraldlo] Add UPPER, LOWER, MAX and MIN into hive parser ea76d0a [egraldlo] modify the formatting issues b49f25e [egraldlo] modify the formatting issues 1f0bbb5 [egraldlo] system function upper and lower supported 13d3267 [egraldlo] system function upper and lower supported
wangyum
pushed a commit
that referenced
this pull request
May 26, 2023
…936) Related PR: * [SPARK-33480][SQL] Support char/varchar type * [SPARK-34164][SQL] Improve write side varchar check to visit only last few tailing spaces * [SPARK-34130][SQL] Impove preformace for char varchar padding and length check with StaticInvoke * [SPARK-35359][SQL] Insert data with char/varchar datatype will fail when data length exceed length limitation * [SPARK-33641][SQL] Invalidate new char/varchar types in public APIs that produce incorrect results Kent Yao* 2020/12/7, 9:40 PM * [SPARK-33834][SQL] Verify ALTER TABLE CHANGE COLUMN with Char and Varchar Kent Yao* 2020/12/22, 11:07 AM * [SPARK-37643][SQL] when charVarcharAsString is true, for char datatype predicate query should skip rpadding rule fhygh* 2022/4/18, 11:11 PM * [SPARK-34833][SQL][FOLLOWUP] Handle outer references in all the places * [SPARK-34833][SQL] Apply right-padding correctly for correlated subqueries * [SPARK-34233][SQL] FIX NPE for char padding in binary comparison * [SPARK-34192][SQL] Move char padding to write side and remove length check on read side too * [SPARK-33901][SQL] Fix Char and Varchar display error after DDLs * [SPARK-33901][SQL][FOLLOWUP] Add drop table in charvarchar test * [SPARK-37160][SQL] Add a config to optionally disable padding for char type * [SPARK-33892][SQL] Display char/varchar in DESC and SHOW CREATE TABLE * [SPARK-34233][SQL] FIX NPE for char padding in binary comparison * [SPARK-39052][SQL] Support Literal.create(Char, StringType) * [SPARK-34908][SQL][TESTS] Add test cases for char and varchar with functions * [SPARK-33879][SQL] Char Varchar values fails w/ match error as partition columns * [SPARK-33591][SQL][3.0] Recognize null in partition spec values * [SPARK-34203][SQL][3.0] Convert null partition values to __HIVE_DEFAULT_PARTITION__ in v1 In-Memory catalog * [SPARK-35244][SQL] Invoke should throw the original exception [NOT-MERGED][SPARK-37452][SQL] Char and Varchar break backward compatibility between v3.1 and v2 [NOT-MERGED][SPARK-35700][SQL] Read char/varchar orc table with created and written by external systems [NOT Merged][SPARK-33834][SQL] Verify ALTER TABLE CHANGE COLUMN with Char and Varchar Kent Yao* 2020/12/22, 11:07 AM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know whether it's time to implement system function about string operation in spark sql now.