Skip to content

[SPARK-1995][SQL] system function upper and lower can be supported #936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
egraldlo wants to merge 5 commits into from
Closed

[SPARK-1995][SQL] system function upper and lower can be supported #936

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
13d3267
system function upper and lower supported
egraldlo Jun 1, 2014
1f0bbb5
system function upper and lower supported
egraldlo Jun 1, 2014
b49f25e
modify the formatting issues
egraldlo Jun 2, 2014
ea76d0a
modify the formatting issues
egraldlo Jun 2, 2014
3c6c60a
Add UPPER, LOWER, MAX and MIN into hive parser
egraldlo Jun 2, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
system function upper and lower supported
  • Loading branch information
@egraldlo
egraldlo committed Jun 1, 2014
commit 1f0bbb5d672856764901cc9676ea7795d08e4ddb
2 changes: 1 addition & 1 deletion sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringOperations.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ trait CaseConversionExpression {
def convert(v: String): String

def nullable: Boolean = true
Copy link
Contributor

@marmbrus marmbrus Jun 2, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can it be null if the child is not nullable?

def dataType: DataType = BooleanType
def dataType: DataType = StringType

override def eval(input: Row): Any = {
val beConverted = child.eval(input)
Copy link
Contributor

@liancheng liancheng Jun 2, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

converted seems better than beConverted here.

Expand Down