Skip to content

[SPARK-11829] [ML] Add read/write to estimators under ml.feature (II) #9838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yanboliang wants to merge 8 commits into from
Closed

[SPARK-11829] [ML] Add read/write to estimators under ml.feature (II) #9838

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0778a49
Add read/write support to ChiSqSelector, PCA, VectorIndexer
yanboliang Nov 19, 2015
cc92a39
Add read/write support to Word2Vec
yanboliang Nov 19, 2015
de3822e
code clean up
yanboliang Nov 19, 2015
5e79781
add @Since
yanboliang Nov 19, 2015
a6c8c80
fix type erasure
yanboliang Nov 19, 2015
e3d5fc6
fix typo
yanboliang Nov 19, 2015
ec969de
update PCA test case
yanboliang Nov 19, 2015
0cb01a3
address comments
yanboliang Nov 20, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
code clean up
  • Loading branch information
@yanboliang
yanboliang committed Nov 19, 2015
commit de3822efd896233313d23144a6f3fb08c380932b
2 changes: 1 addition & 1 deletion mllib/src/main/scala/org/apache/spark/ml/feature/Word2Vec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,7 @@ object Word2VecModel extends MLReadable[Word2VecModel] {

override protected def saveImpl(path: String): Unit = {
DefaultParamsWriter.saveMetadata(instance, path, sc)
val data = Data(instance.wordVectors.wordIndex, instance.wordVectors.wordVectors)
val data = Data(instance.wordVectors.wordIndex, instance.wordVectors.wordVectors.toSeq)
val dataPath = new Path(path, "data").toString
sqlContext.createDataFrame(Seq(data)).repartition(1).write.parquet(dataPath)
}
Expand Down
2 changes: 1 addition & 1 deletion mllib/src/test/scala/org/apache/spark/ml/feature/VectorIndexerSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ import scala.beans.{BeanInfo, BeanProperty}
import org.apache.spark.{Logging, SparkException, SparkFunSuite}
import org.apache.spark.ml.attribute._
import org.apache.spark.ml.param.ParamsSuite
import org.apache.spark.ml.util.{MLTestingUtils, DefaultReadWriteTest}
import org.apache.spark.ml.util.{DefaultReadWriteTest, MLTestingUtils}
import org.apache.spark.mllib.linalg.{SparseVector, Vector, Vectors}
import org.apache.spark.mllib.util.MLlibTestSparkContext
import org.apache.spark.rdd.RDD
Expand Down
10 changes: 5 additions & 5 deletions mllib/src/test/scala/org/apache/spark/ml/feature/Word2VecSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,12 +148,12 @@ class Word2VecSuite extends SparkFunSuite with MLlibTestSparkContext with Defaul
val t = new Word2Vec()
.setInputCol("myInputCol")
.setOutputCol("myOutputCol")
.setMaxIter(5)
.setMinCount(10)
.setNumPartitions(2)
.setMaxIter(2)
.setMinCount(8)
.setNumPartitions(1)
.setSeed(42L)
.setStepSize(0.015)
.setVectorSize(200)
.setStepSize(0.01)
.setVectorSize(100)
testDefaultReadWrite(t)
}

Expand Down