-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-11829] [ML] Add read/write to estimators under ml.feature (II) #9838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
0778a49
Add read/write support to ChiSqSelector, PCA, VectorIndexer
yanboliang cc92a39
Add read/write support to Word2Vec
yanboliang de3822e
code clean up
yanboliang 5e79781
add @Since
yanboliang a6c8c80
fix type erasure
yanboliang e3d5fc6
fix typo
yanboliang ec969de
update PCA test case
yanboliang 0cb01a3
address comments
yanboliang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
update PCA test case
- Loading branch information
commit ec969de60592a92fdb7f7338f7b74d7e144732fe
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same as StandardScalerModel, we can not construct PCAModel directly by specifying the variable
k, so test estimator and model in one case withtestEstimatorAndModelReadWrite.