Support more channel requests. #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: We only supported three channel request types before. Now we support everything in the RFC that isn't X11 related, because we're not planning to support X11 at this time anyway. Modifications: - Added lots of new user events - Expanded SSHMessage.ChannelRequestMessage - Tested that all of these objects round-trip. Result: Many more things we can do with SSH.
Member
|
lets merge #3 first so we can get CI to actually test this |
Contributor
Author
|
Hey @tomerd, I can’t follow the link to the failing sanity checker: any idea why? |
artemredkin
approved these changes
Apr 24, 2020
Conflicts: Sources/NIOSSH/SSHMessages.swift Tests/LinuxMain.swift
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We only supported three channel request types before. Now we support
everything in the RFC that isn't X11 related, because we're not planning
to support X11 at this time anyway.
Modifications:
Result:
Many more things we can do with SSH.