Skip to content

Conversation

@tomerd
Copy link
Member

@tomerd tomerd commented Apr 23, 2020

motivation: setup continous integration

changes:

  • add docker and docker-compose setup
  • fix sanity script
  • add formatting rules + format

@tomerd
Copy link
Member Author

tomerd commented Apr 23, 2020

@swift-server-bot test this please

@tomerd tomerd requested review from Lukasa and artemredkin and removed request for Lukasa April 23, 2020 20:20
motivation: setup continous integration

changes:
* add docker and docker-compose setup
* fix sanity script
* add formatting rules + format
Copy link
Contributor

@Lukasa Lukasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, I utterly loathe implicit return.

@Lukasa Lukasa merged commit 6a45fd6 into apple:master Apr 23, 2020
@Lukasa Lukasa deleted the ci-setup branch April 23, 2020 20:47
@tomerd
Copy link
Member Author

tomerd commented Apr 23, 2020

Wow, I utterly loathe implicit return.

we can change the formatting rules if you want

@Lukasa
Copy link
Contributor

Lukasa commented Apr 24, 2020

It’s ok, I’d rather not spend any mental effort customising this. I just discovered in this diff that it looks awful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants