Skip to content

Conversation

@dnadoba
Copy link
Member

@dnadoba dnadoba commented Jul 8, 2022

NIOAtomics was deprecated in apple/swift-nio#2204 in favor of swift-atomics https://github.com/apple/swift-atomics
In addition, the @preconcrrency imports of NIOCore are not required and do not produce warnings/errors even with the currently latest released version of swift-nio (2.40.0), changes from main are not required.

@dnadoba dnadoba added the 🔨 semver/patch No public API change. label Jul 8, 2022
`NIOAtomics` was deprecated in apple/swift-nio#2204 in favor of `swift-atomics` https://github.com/apple/swift-atomics
In addition, the `@preconcrrency` imports of `NIOCore` are not required and do not produce warnings/errors even with the currently latest released version of swift-nio (2.40.0), changes from `main` are not required.
Copy link
Contributor

@glbrntt glbrntt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks David!

@glbrntt glbrntt merged commit 27bf96b into apple:main Jul 8, 2022
@dnadoba dnadoba deleted the dn-atomics branch July 8, 2022 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🔨 semver/patch No public API change.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants