Deprecate `NIOAtomics` in favor of `Atomics` #2204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

Lukasa merged 12 commits into apple:main from stevapple:swift-atomics

Jul 1, 2022

Contributor

stevapple commented Jun 24, 2022

Deprecate NIOAtomics in favor of Atomics, and replace all usages of NIOAtomic.

Motivation:

Since we have an official Atomics library, we can move from our own Atomics implementation to it.
Resolves #1948.

Modifications:

NIOAtomic and UnsafeEmbeddedAtomic wrapper types are now deprecated;
Swift NIO implementations and tests are moving from NIOAtomic to ManagedAtomic.

Result:

We no longer need to maintain our own atomic types.
NIO will gain a dependency on swift-atomics package.

stevapple added 6 commits

June 25, 2022 01:41


          Deprecate NIOAtomics in favor of Atomics

61bf6bc


          Update NIOEmbedded to use Atomics

587a95b


          Update NIOPosix to use Atomics

46fee61


          Update NIOTestUtils to use Atomics

1f7ac3b


          Deprecate tests for NIOAtomic

ee2d280


          Update tests to use Atomics

4b0d4a9

swift-server-bot commented Jun 24, 2022

Can one of the admins verify this patch?

11 similar comments

swift-server-bot commented Jun 24, 2022

Can one of the admins verify this patch?

swift-server-bot commented Jun 24, 2022

Can one of the admins verify this patch?

swift-server-bot commented Jun 24, 2022

Can one of the admins verify this patch?

swift-server-bot commented Jun 24, 2022

Can one of the admins verify this patch?

swift-server-bot commented Jun 24, 2022

Can one of the admins verify this patch?

swift-server-bot commented Jun 24, 2022

Can one of the admins verify this patch?

swift-server-bot commented Jun 24, 2022

Can one of the admins verify this patch?

swift-server-bot commented Jun 24, 2022

Can one of the admins verify this patch?

swift-server-bot commented Jun 24, 2022

Can one of the admins verify this patch?

swift-server-bot commented Jun 24, 2022

Can one of the admins verify this patch?

swift-server-bot commented Jun 24, 2022

Can one of the admins verify this patch?

Contributor Author

stevapple commented Jun 24, 2022

Note that ordering is set to .relaxed everywhere to preserve NIOAtomic's behavior. We can fine-tune the behavior later.

stevapple mentioned this pull request

Replace NIOAtomics with swift-atomics #1948

Closed

Lukasa added the 🆕 semver/minor label

Lukasa reviewed

View reviewed changes

Contributor

Lukasa left a comment

Fantastic, I'm really excited to see this come along. I have a few exceedingly tiny nits but otherwise I think this is a perfect patch and ready to go in. cc @weissi in case he's curious, and @lorentey because I know this is a thing he's wanted for a long time!

Package.swift Outdated Show resolved Hide resolved

Sources/NIOPosix/PendingDatagramWritesManager.swift Outdated Show resolved Hide resolved

Sources/NIOPosix/PendingWritesManager.swift Outdated Show resolved Hide resolved

Contributor

Lukasa commented Jun 25, 2022

@swift-nio-bot add to allowlist

Contributor Author

stevapple commented Jun 25, 2022

Sendable appears to be a problem for Swift 5.5, where @preconcurrency is not available.

I’ll ping on apple/swift-atomics#45 for this.

Member

dnadoba commented Jun 25, 2022

EventCounterHandler has adopted Sendable in #2199 which is not yet part of any release. We could therefore just remove Sendable in Swift <= 5.5 as an alternative without actually breaking API.

stevapple added 4 commits

June 26, 2022 21:28


          NIO style fix

b6c2d05


          Remove Sendable conformance for EventCounterHandler in Swift 5.5

18b0b5f


          Fix concurrency checking on main

abb3081


          Use Atomics 1.0.2

7ddd6df

Contributor Author

stevapple commented Jun 26, 2022

cc @Lukasa @dnadoba

dnadoba reviewed

View reviewed changes

Member

dnadoba left a comment

Thanks a lot @stevapple! Looks good from my side but we definitely need to wait for Cory's review.

Sources/NIOConcurrencyHelpers/NIOAtomic.swift Outdated Show resolved Hide resolved

Sources/NIOConcurrencyHelpers/atomics.swift Outdated Show resolved Hide resolved

Sources/NIOConcurrencyHelpers/atomics.swift Outdated Show resolved Hide resolved


          Update deprecation messages

bcd97b8

Lukasa approved these changes

View reviewed changes

Contributor

Lukasa commented Jun 28, 2022

@swift-nio-bot test this please


          Merge branch 'main' into swift-atomics

7c3b067

Lukasa enabled auto-merge (squash)

July 1, 2022 09:16

Lukasa merged commit a501353 into apple:main

stevapple deleted the swift-atomics branch

July 3, 2022 11:17

dnadoba mentioned this pull request

Use swift-atomics instead of NIOAtomics apple/swift-nio-transport-services#153

Merged

dnadoba added a commit to dnadoba/swift-nio-ssh that referenced this pull request


          Use swift-atomics instead of NIOAtomics

669cab2

`NIOAtomics` was deprecated in apple/swift-nio#2204 in favor of `swift-atomics` https://github.com/apple/swift-atomics
In addition, the `@preconcrrency` imports of `NIOCore` are not required and do not produce warnings/errors even with the currently latest released version of swift-nio (2.40.0), changes from `main` are not required.

dnadoba mentioned this pull request

Use swift-atomics instead of NIOAtomics apple/swift-nio-ssh#117

Merged

dnadoba added a commit to dnadoba/swift-nio-ssh that referenced this pull request


          Use swift-atomics instead of NIOAtomics

e897c0f

`NIOAtomics` was deprecated in apple/swift-nio#2204 in favor of `swift-atomics` https://github.com/apple/swift-atomics
In addition, the `@preconcrrency` imports of `NIOCore` are not required and do not produce warnings/errors even with the currently latest released version of swift-nio (2.40.0), changes from `main` are not required.

dnadoba added a commit to dnadoba/swift-nio-http2 that referenced this pull request


          Use swift-atomics instead of NIOAtomics

990667b

`NIOAtomics` was deprecated in apple/swift-nio#2204 in favor of `swift-atomics` https://github.com/apple/swift-atomics

dnadoba mentioned this pull request

Use swift-atomics instead of NIOAtomics apple/swift-nio-http2#350

Merged

glbrntt pushed a commit to apple/swift-nio-ssh that referenced this pull request


          Use swift-atomics instead of NIOAtomics (#117)

27bf96b

`NIOAtomics` was deprecated in apple/swift-nio#2204 in favor of `swift-atomics` https://github.com/apple/swift-atomics
In addition, the `@preconcrrency` imports of `NIOCore` are not required and do not produce warnings/errors even with the currently latest released version of swift-nio (2.40.0), changes from `main` are not required.

dnadoba added a commit to dnadoba/async-http-client that referenced this pull request


          Use swift-atomics instead of NIOAtomics

e0b311e

`NIOAtomics` was deprecated in apple/swift-nio#2204 in favor of `swift-atomics` https://github.com/apple/swift-atomics

dnadoba mentioned this pull request

Use swift-atomics instead of NIOAtomics swift-server/async-http-client#603

Merged

glbrntt pushed a commit to apple/swift-nio-http2 that referenced this pull request


          Use swift-atomics instead of NIOAtomics (#350)

f9ab1c9

`NIOAtomics` was deprecated in apple/swift-nio#2204 in favor of `swift-atomics` https://github.com/apple/swift-atomics

glbrntt added a commit to glbrntt/grpc-swift that referenced this pull request


          Use swift-atomics

aeb32bc

Motivation:

NIO deprecated its atomics in apple/swift-nio#2204.

Modifications:

- Use swift-atomics in the `QPSBenchmark` sub-package
- Use a lock in the one test which used `NIOAtomic`

Result:

Not using deprecated code.

glbrntt mentioned this pull request

Use swift-atomics grpc/grpc-swift#1453

Merged

glbrntt added a commit to glbrntt/grpc-swift that referenced this pull request


          Use swift-atomics

f0c4f80

Motivation:

NIO deprecated its atomics in apple/swift-nio#2204.

Modifications:

- Use swift-atomics in the `QPSBenchmark` sub-package
- Use a lock in the one test which used `NIOAtomic`

Result:

Not using deprecated code.

glbrntt added a commit to grpc/grpc-swift that referenced this pull request


          Use swift-atomics (#1453)

ac0a76d

Motivation:

NIO deprecated its atomics in apple/swift-nio#2204.

Modifications:

- Use swift-atomics in the `QPSBenchmark` sub-package
- Use a lock in the one test which used `NIOAtomic`

Result:

Not using deprecated code.

dnadoba added a commit to swift-server/async-http-client that referenced this pull request


          Use swift-atomics instead of NIOAtomics (#603)

2adca4b

`NIOAtomics` was deprecated in apple/swift-nio#2204 in favor of `swift-atomics` https://github.com/apple/swift-atomics

Joannis pushed a commit to Joannis/swift-nio-ssh that referenced this pull request


          Use swift-atomics instead of NIOAtomics (#117)

fd21ed2

`NIOAtomics` was deprecated in apple/swift-nio#2204 in favor of `swift-atomics` https://github.com/apple/swift-atomics
In addition, the `@preconcrrency` imports of `NIOCore` are not required and do not produce warnings/errors even with the currently latest released version of swift-nio (2.40.0), changes from `main` are not required.

luke960305 pushed a commit to luke960305/grpc-swift that referenced this pull request


          Use swift-atomics (#1453)

6c72023

Motivation:

NIO deprecated its atomics in apple/swift-nio#2204.

Modifications:

- Use swift-atomics in the `QPSBenchmark` sub-package
- Use a lock in the one test which used `NIOAtomic`

Result:

Not using deprecated code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🆕 semver/minor