Lower alloc limits to lock-in upstream wins #173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Changes in swift-nio and swift-atomics have resulted in fewer allocations in the benchmarks in swift-nio-ssh, so much improved that it caused tests to fail. Modifications: Update the limits to take account of the gains, update the script to scrape the new limits to use 5.8, 5.9, 5.10. Result: Allocation benchmark CI should pass again.
FranzBusch
approved these changes
Oct 15, 2024
Lukasa
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Changes in swift-nio and swift-atomics have resulted in fewer allocations in the benchmarks in swift-nio-ssh, so much improved that it caused tests to fail.
Modifications:
Update the limits to take account of the gains, update the script to scrape the new limits to use 5.8, 5.9, 5.10.
Result:
Allocation benchmark CI should pass again.