Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Lower alloc limits to lock-in upstream wins
Motivation:

Changes in swift-nio and swift-atomics have resulted in fewer
allocations in the benchmarks in swift-nio-ssh, so much improved that it
caused tests to fail.

Modifications:

Update the limits to take account of the gains, update the script to
scrape the new limits to use 5.8, 5.9, 5.10.

Result:

Allocation benchmark CI should pass again.
  • Loading branch information
rnro committed Oct 15, 2024
commit 4c824e942d975563ac432c82f04103590752dfa7
2 changes: 1 addition & 1 deletion dev/update-alloc-limits-to-last-completed-ci-build
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ url_prefix=${1-"https://ci.swiftserver.group/job/swift-nio-ssh-"}
target_repo=${2-"$here/.."}
tmpdir=$(mktemp -d /tmp/.last-build_XXXXXX)

for f in 56 57 58 59 nightly; do
for f in 58 59 510 nightly; do
echo "swift$f"
if [[ "$f" == "nightly" ]]; then
url="$url_prefix$f-prb/lastCompletedBuild/consoleFull"
Expand Down
6 changes: 3 additions & 3 deletions docker/docker-compose.2204.510.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@ services:
test:
image: swift-nio-ssh:22.04-5.10
environment:
- MAX_ALLOCS_ALLOWED_client_server_many_small_commands_per_connection=193750
- MAX_ALLOCS_ALLOWED_client_server_one_command_per_connection=939050
- MAX_ALLOCS_ALLOWED_client_server_streaming_large_message_in_small_chunks=40950
- MAX_ALLOCS_ALLOWED_client_server_many_small_commands_per_connection=192700
- MAX_ALLOCS_ALLOWED_client_server_one_command_per_connection=852050
- MAX_ALLOCS_ALLOWED_client_server_streaming_large_message_in_small_chunks=40850
- IMPORT_CHECK_ARG=--explicit-target-dependency-import-check error
#- SANITIZER_ARG=--sanitize=thread
- WARN_AS_ERROR_ARG=-Xswiftc -warnings-as-errors
Expand Down
6 changes: 3 additions & 3 deletions docker/docker-compose.2204.58.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@ services:
test:
image: swift-nio-ssh:22.04-5.8
environment:
- MAX_ALLOCS_ALLOWED_client_server_many_small_commands_per_connection=193750
- MAX_ALLOCS_ALLOWED_client_server_one_command_per_connection=939050
- MAX_ALLOCS_ALLOWED_client_server_streaming_large_message_in_small_chunks=40950
- MAX_ALLOCS_ALLOWED_client_server_many_small_commands_per_connection=192700
- MAX_ALLOCS_ALLOWED_client_server_one_command_per_connection=852050
- MAX_ALLOCS_ALLOWED_client_server_streaming_large_message_in_small_chunks=40850
- IMPORT_CHECK_ARG=--explicit-target-dependency-import-check error
#- SANITIZER_ARG=--sanitize=thread
- WARN_AS_ERROR_ARG=-Xswiftc -warnings-as-errors
Expand Down
6 changes: 3 additions & 3 deletions docker/docker-compose.2204.59.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@ services:
test:
image: swift-nio-ssh:22.04-5.9
environment:
- MAX_ALLOCS_ALLOWED_client_server_many_small_commands_per_connection=199800
- MAX_ALLOCS_ALLOWED_client_server_one_command_per_connection=949050
- MAX_ALLOCS_ALLOWED_client_server_streaming_large_message_in_small_chunks=42950
- MAX_ALLOCS_ALLOWED_client_server_many_small_commands_per_connection=198700
- MAX_ALLOCS_ALLOWED_client_server_one_command_per_connection=862050
- MAX_ALLOCS_ALLOWED_client_server_streaming_large_message_in_small_chunks=42850
- IMPORT_CHECK_ARG=--explicit-target-dependency-import-check error
#- SANITIZER_ARG=--sanitize=thread
- WARN_AS_ERROR_ARG=-Xswiftc -warnings-as-errors
Expand Down
6 changes: 3 additions & 3 deletions docker/docker-compose.2204.main.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@ services:
test:
image: swift-nio-ssh:22.04-main
environment:
- MAX_ALLOCS_ALLOWED_client_server_many_small_commands_per_connection=193750
- MAX_ALLOCS_ALLOWED_client_server_one_command_per_connection=939050
- MAX_ALLOCS_ALLOWED_client_server_streaming_large_message_in_small_chunks=40950
- MAX_ALLOCS_ALLOWED_client_server_many_small_commands_per_connection=192700
- MAX_ALLOCS_ALLOWED_client_server_one_command_per_connection=852050
- MAX_ALLOCS_ALLOWED_client_server_streaming_large_message_in_small_chunks=40850
- IMPORT_CHECK_ARG=--explicit-target-dependency-import-check error
#- SANITIZER_ARG=--sanitize=thread
- WARN_AS_ERROR_ARG=-Xswiftc -warnings-as-errors
Expand Down