Define new configuration logic and global request delegate #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: As part of the work for TCP port forwarding support we need a way for "global requests" to be handled. This implies the existence of a "Global Request Delegate". When adding this it became clear that configuration was getting out of hand. This patch rewrites configuration to make it a bit easier to handle. Modifications: - Added new GlobalRequestDelegate - Added SSHClientConfiguration and SSHServerConfiguration - Moved existing delegate and host key setup under the new config. - Fixed up the tests. Results: Single configuration object.
Member
|
lets merge #3 first so we can get CI to actually test this |
artemredkin
approved these changes
Apr 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
As part of the work for TCP port forwarding support we need a way for
"global requests" to be handled. This implies the existence of a "Global
Request Delegate". When adding this it became clear that configuration
was getting out of hand. This patch rewrites configuration to make it a
bit easier to handle.
Modifications:
Results:
Single configuration object.