Skip to content

Prefer AES-256 to AES-128. #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lukasa merged 1 commit into from
May 29, 2020
Merged

Prefer AES-256 to AES-128. #25

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prefer AES-256 to AES-128. 
Motivation:

The industry has been moving towards preferring larger key sizes in AES.
We should reflect that.

Modifications:

- Prefer AES-256 to AES-128.

Result:

More connections with larger key sizes.
  • Loading branch information
@Lukasa
Lukasa committed May 29, 2020
commit 51a3dfe89edd95fa80e12a68ed4a615c730aa27a
2 changes: 1 addition & 1 deletion Sources/NIOSSH/Connection State Machine/SSHConnectionStateMachine.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ struct SSHConnectionStateMachine {
private var state: State

private static let defaultTransportProtectionSchemes: [NIOSSHTransportProtection.Type] = [
AES128GCMOpenSSHTransportProtection.self, AES256GCMOpenSSHTransportProtection.self,
AES256GCMOpenSSHTransportProtection.self, AES128GCMOpenSSHTransportProtection.self,
]

init(role: SSHConnectionRole, protectionSchemes: [NIOSSHTransportProtection.Type] = Self.defaultTransportProtectionSchemes) {
Expand Down