Skip to content

Deprecate NIOAtomics in favor of Atomics #2204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lukasa merged 12 commits into from
Jul 1, 2022
Merged

Deprecate NIOAtomics in favor of Atomics #2204

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
61bf6bc
Deprecate `NIOAtomics` in favor of `Atomics`
stevapple Jun 24, 2022
587a95b
Update `NIOEmbedded` to use `Atomics`
stevapple Jun 24, 2022
46fee61
Update `NIOPosix` to use `Atomics`
stevapple Jun 24, 2022
1f7ac3b
Update `NIOTestUtils` to use `Atomics`
stevapple Jun 24, 2022
ee2d280
Deprecate tests for `NIOAtomic`
stevapple Jun 24, 2022
4b0d4a9
Update tests to use `Atomics`
stevapple Jun 24, 2022
b6c2d05
NIO style fix
stevapple Jun 26, 2022
18b0b5f
Remove `Sendable` conformance for `EventCounterHandler` in Swift 5.5
stevapple Jun 26, 2022
abb3081
Fix concurrency checking on `main`
stevapple Jun 26, 2022
7ddd6df
Use Atomics 1.0.2
stevapple Jun 26, 2022
bcd97b8
Update deprecation messages
stevapple Jun 28, 2022
7c3b067
Merge branch 'main' into swift-atomics
Lukasa Jul 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update deprecation messages
  • Loading branch information
@stevapple
stevapple committed Jun 28, 2022
commit bcd97b85578bff324b9dacb9358101c1bf06f57c
2 changes: 1 addition & 1 deletion Sources/NIOConcurrencyHelpers/NIOAtomic.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ extension UInt: NIOAtomicPrimitive {
/// By necessity, all atomic values are references: after all, it makes no
/// sense to talk about managing an atomic value when each time it's modified
/// the thread that modified it gets a local copy!
@available(*, deprecated, message:"please use Atomics.ManagedAtomic instead")
@available(*, deprecated, message:"please use ManagedAtomic from https://github.com/apple/swift-atomics instead")
public final class NIOAtomic<T: NIOAtomicPrimitive> {
@usableFromInline
typealias Manager = ManagedBufferPointer<Void, T.AtomicWrapper>
Expand Down
4 changes: 2 additions & 2 deletions Sources/NIOConcurrencyHelpers/atomics.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ fileprivate func sys_sched_yield() {
/// Atomic primitives are useful when building constructs that need to
/// communicate or cooperate across multiple threads. In the case of
/// SwiftNIO this usually involves communicating across multiple event loops.
@available(*, deprecated, message: "please use Atomics.UnsafeAtomic instead")
@available(*, deprecated, message: "please use UnsafeAtomic from https://github.com/apple/swift-atomics instead")
public struct UnsafeEmbeddedAtomic<T: AtomicPrimitive> {
@usableFromInline
internal let value: OpaquePointer
Expand Down Expand Up @@ -174,7 +174,7 @@ public struct UnsafeEmbeddedAtomic<T: AtomicPrimitive> {
/// By necessity, all atomic values are references: after all, it makes no
/// sense to talk about managing an atomic value when each time it's modified
/// the thread that modified it gets a local copy!
@available(*, deprecated, message:"please use Atomics.ManagedAtomic instead")
@available(*, deprecated, message:"please use ManagedAtomic from https://github.com/apple/swift-atomics instead")
public final class Atomic<T: AtomicPrimitive> {
@usableFromInline
internal let embedded: UnsafeEmbeddedAtomic<T>
Expand Down