fix(controller): validation failed when dynamic templateRef is used in nested template #14053
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
…n nested template Signed-off-by: joey <[email protected]>
chengjoey
force-pushed
the
fix/dynamic-tmplref
branch
from
64c1f7b to
972ed7e
Compare
isubasinghe
pushed a commit
to pipekit/argo-workflows
that referenced
this pull request
Jan 30, 2025
…n nested template (argoproj#14053) Signed-off-by: joey <[email protected]>
isubasinghe
pushed a commit
to pipekit/argo-workflows
that referenced
this pull request
Jan 31, 2025
…n nested template (argoproj#14053) Signed-off-by: joey <[email protected]>
isubasinghe
pushed a commit
that referenced
this pull request
Jan 31, 2025
…n nested template (#14053) Signed-off-by: joey <[email protected]>
Joibel
pushed a commit
that referenced
this pull request
Feb 7, 2025
…n nested template (#14053) Signed-off-by: joey <[email protected]> (cherry picked from commit 82537a7)
This was referenced Feb 10, 2025
Member
Joibel
added a commit
to pipekit/argo-workflows
that referenced
this pull request
Feb 10, 2025
…s used in nested template (argoproj#14053)" This reverts commit 59026f5.
Joibel
added a commit
that referenced
this pull request
Feb 10, 2025
…s used in nested template (#14053)" This reverts commit 82537a7. Signed-off-by: Alan Clucas <[email protected]>
Joibel
added a commit
that referenced
this pull request
Feb 10, 2025
Signed-off-by: Alan Clucas <[email protected]>
4 tasks
tczhao
added a commit
to tczhao/argo
that referenced
this pull request
Feb 19, 2025
…s used in nested template (argoproj#14053)" This reverts commit 7fe50f3.
criscola
pushed a commit
to helio/argo-workflows
that referenced
this pull request
Mar 13, 2025
…n nested template (argoproj#14053) Signed-off-by: joey <[email protected]> (cherry picked from commit 82537a7)
criscola
pushed a commit
to helio/argo-workflows
that referenced
this pull request
Mar 13, 2025
…s used in nested template (argoproj#14053)" This reverts commit 59026f5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14042 #13773
Motivation
if nested template has reference, input tmpl args
Verification
unit test