fix: skip validate dynamic templateref #14850
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tianchu Zhao <[email protected]>
Signed-off-by: Tianchu Zhao <[email protected]>
Signed-off-by: Tianchu Zhao <[email protected]>
tczhao
changed the title
Joibel
requested changes
Sep 30, 2025
| tmplCtx, resolvedTmpl, _, err := tmplCtx.ResolveTemplate(ctx, tmplHolder) | ||
| if err != nil { | ||
| if argoerr, ok := err.(errors.ArgoError); ok && argoerr.Code() == errors.CodeNotFound { | ||
| if tmplRef != nil && strings.Contains(tmplRef.Template, "placeholder") { |
Member
There was a problem hiding this comment.
Can we make it less likely to mismatch on non-placeholder templates with
Suggested change
| if tmplRef != nil && strings.Contains(tmplRef.Template, "placeholder") { | |
| if tmplRef != nil && strings.HasPrefix(tmplRef.Template, "placeholder") { |
Member
Author
There was a problem hiding this comment.
The dynamic template parameter can be partial, using prefix matching won't cover the following use case.
e.g.
"prod-{{ inputs.parameters.message }}" this will translate to prod-placeholder-x.
If a user uses string:placeholder in templateRef, the worst-case scenario is that they experience an issue during runtime instead of catch it at the validation phase.
Joibel
approved these changes
Oct 6, 2025
| tmplCtx, resolvedTmpl, _, err := tmplCtx.ResolveTemplate(ctx, tmplHolder) | ||
| if err != nil { | ||
| if argoerr, ok := err.(errors.ArgoError); ok && argoerr.Code() == errors.CodeNotFound { | ||
| if tmplRef != nil && strings.Contains(tmplRef.Template, "placeholder") { |
survivant
pushed a commit
to survivant/argo-workflows
that referenced
this pull request
Oct 7, 2025
Signed-off-by: Tianchu Zhao <[email protected]> Signed-off-by: Sebastien Dionne <[email protected]>
ItielOlenick
pushed a commit
to ItielOlenick/argo-workflows
that referenced
this pull request
Oct 26, 2025
Signed-off-by: Tianchu Zhao <[email protected]>
4 tasks
Joibel
added
cherry-pick/3.7
|
❌ Cherry-pick failed for 3.6. Please check the workflow logs for details. |
|
❌ Cherry-pick failed for 3.7. Please check the workflow logs for details. |
Joibel
pushed a commit
that referenced
this pull request
Nov 26, 2025
(cherry picked from commit d1b280e) Signed-off-by: Tianchu Zhao <[email protected]> Signed-off-by: Alan Clucas <[email protected]>
Joibel
pushed a commit
that referenced
this pull request
Nov 26, 2025
(cherry picked from commit d1b280e) Signed-off-by: Tianchu Zhao <[email protected]> Signed-off-by: Alan Clucas <[email protected]>
Joibel
pushed a commit
that referenced
this pull request
Nov 26, 2025
(cherry picked from commit d1b280e) Signed-off-by: Tianchu Zhao <[email protected]> Signed-off-by: Alan Clucas <[email protected]>
Joibel
pushed a commit
that referenced
this pull request
Nov 26, 2025
(cherry picked from commit d1b280e) Signed-off-by: Tianchu Zhao <[email protected]> Signed-off-by: Alan Clucas <[email protected]>
Joibel
added a commit
that referenced
this pull request
Nov 26, 2025
…15082) Signed-off-by: Tianchu Zhao <[email protected]> Signed-off-by: Alan Clucas <[email protected]> Co-authored-by: Tianchu Zhao <[email protected]>
Joibel
added a commit
that referenced
this pull request
Nov 26, 2025
…15081) Signed-off-by: Tianchu Zhao <[email protected]> Signed-off-by: Alan Clucas <[email protected]> Co-authored-by: Tianchu Zhao <[email protected]>
This was referenced Dec 8, 2025
guanguxiansheng
pushed a commit
to guanguxiansheng/argo-workflows
that referenced
this pull request
Dec 15, 2025
Signed-off-by: Tianchu Zhao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14042 #13773
Before this fix, the validation will failed if workflow contains dynamic templateRef.
Decide to skip validate dynamic templateRef instead of find a way to validate them due to the complexity and cases where its impossible to validate
Motivation
Modifications
Verification
Added test for dynamic templateRef validation. copy from #14053
Added test to validate the regression introduced by previous templateRef validation implementation attempt
Documentation