-
Notifications
You must be signed in to change notification settings - Fork 3.4k
docs: autogenerate features for 4.0-rc1 #15148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Alan Clucas <[email protected]>
cbdae0d to
d4a2655
Compare
gianarb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a little review coming from looking at #15149
| * Parameters: 500 | ||
| * Prometheus metrics per template: 100 | ||
| * Gauge metric value string: 256 characters | ||
| #### Mutual Exclusivity Rules: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
according to the new-feaures generator tool this goes from ## General to #### Mutual, it should go to ### Mutual (one less #). And it should be a blank line before and after but the generator I think strips them as part of merging the various features file as point in a list.
All the others following suffer the same issue
| **Note:** Some validations cannot be implemented as CEL rules due to Kubernetes limitations. | ||
| Fields marked with `+kubebuilder:validation:Schemaless` (like `withItems`) or `+kubebuilder:pruning:PreserveUnknownFields` (like `inline`) are not visible to CEL validation expressions. | ||
| **CEL Budget Management:** Kubernetes limits the total cost of CEL validation rules per CRD. To stay within these limits: | ||
| * All `status` blocks have CEL validations automatically stripped during CRD generation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
according to the linter those should not be * but -
| - Support open custom links in new tab automatically. by [Shuangkun Tian](https://github.com/shuangkun) ([#13114](https://github.com/argoproj/argo-workflows/issues/13114)) | ||
| Support configuring a custom link to open in a new tab by default. | ||
| If target == _blank, open in new tab, if target is null or _self, open in this tab. For example: | ||
| ``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should specify the language for consistency with the other code blocks
gianarb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For me this is good to go. It is also blocking this PR that I am working on to enable back the lining that this PR disables
This is an automated update of new-features ready for 4.0-rc1. As per https://argo-workflows.readthedocs.io/en/latest/releasing/#documentation.
I've had to suppress spelling and linting of this file. I've raised #15149 to address this