Skip to content

Conversation

@Joibel
Copy link
Member

@Joibel Joibel commented Dec 11, 2025

This is an automated update of new-features ready for 4.0-rc1. As per https://argo-workflows.readthedocs.io/en/latest/releasing/#documentation.

I've had to suppress spelling and linting of this file. I've raised #15149 to address this

@Joibel Joibel marked this pull request as draft December 11, 2025 09:42
@Joibel Joibel added the area/docs Incorrect, missing, or mistakes in docs label Dec 11, 2025
@Joibel Joibel marked this pull request as ready for review December 11, 2025 11:20
Copy link
Contributor

@gianarb gianarb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a little review coming from looking at #15149

* Parameters: 500
* Prometheus metrics per template: 100
* Gauge metric value string: 256 characters
#### Mutual Exclusivity Rules:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

according to the new-feaures generator tool this goes from ## General to #### Mutual, it should go to ### Mutual (one less #). And it should be a blank line before and after but the generator I think strips them as part of merging the various features file as point in a list.

All the others following suffer the same issue

**Note:** Some validations cannot be implemented as CEL rules due to Kubernetes limitations.
Fields marked with `+kubebuilder:validation:Schemaless` (like `withItems`) or `+kubebuilder:pruning:PreserveUnknownFields` (like `inline`) are not visible to CEL validation expressions.
**CEL Budget Management:** Kubernetes limits the total cost of CEL validation rules per CRD. To stay within these limits:
* All `status` blocks have CEL validations automatically stripped during CRD generation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

according to the linter those should not be * but -

- Support open custom links in new tab automatically. by [Shuangkun Tian](https://github.com/shuangkun) ([#13114](https://github.com/argoproj/argo-workflows/issues/13114))
Support configuring a custom link to open in a new tab by default.
If target == _blank, open in new tab, if target is null or _self, open in this tab. For example:
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should specify the language for consistency with the other code blocks

Copy link
Contributor

@gianarb gianarb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me this is good to go. It is also blocking this PR that I am working on to enable back the lining that this PR disables

#15165

@Joibel Joibel merged commit b647bda into main Dec 16, 2025
39 checks passed
@Joibel Joibel deleted the features-40rc1 branch December 16, 2025 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/docs Incorrect, missing, or mistakes in docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants