fix: properly sort trace events #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trace events are not sorted by default. Proper sorting not only uses timestamps, but also accounts for trace event duration. Reference #8
Collaborator
patrickhulce
left a comment
patrickhulce
left a comment
There was a problem hiding this comment.
😮 but...but...but...the devtools files we took our sort from never looked at dur
how come no one has said this before!? 😆 no wonder there are problems we just thought it needed stableSort!
Owner
Author
I wonder!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trace events are not sorted by default. Proper sorting not only uses
timestamps, but also accounts for trace event duration.
Reference #8