Skip to content

fix: properly sort trace events #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aslushnikov merged 1 commit into from
Jun 18, 2019
Merged

fix: properly sort trace events #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: properly sort trace events 
Trace events are not sorted by default. Proper sorting not only uses
timestamps, but also accounts for trace event duration.

Reference #8
  • Loading branch information
@aslushnikov
aslushnikov committed Jun 18, 2019
commit 86cc046c08a936570e7986f8909beae964bd069f
12 changes: 10 additions & 2 deletions lib/trace-of-tab.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,16 @@ class TraceOfTab {

// sort by ts, if there's no ts difference sort by index
indices.sort((indexA, indexB) => {
const result = traceEvents[indexA].ts - traceEvents[indexB].ts;
return result ? result : indexA - indexB;
const tsResult = traceEvents[indexA].ts - traceEvents[indexB].ts;
if (tsResult)
return tsResult;
let tdurResult = 0;
if (traceEvents[indexA].tdur !== undefined && traceEvents[indexB].tdur !== undefined)
tdurResult = traceEvents[indexB].tdur - traceEvents[indexA].tdur;
let durResult = 0;
if (traceEvents[indexA].dur !== undefined && traceEvents[indexB].dur !== undefined)
durResult = traceEvents[indexB].dur - traceEvents[indexA].dur;
return tdurResult || durResult || (indexA - indexB);
});

// create a new array using the target indices from previous sort step
Expand Down
Loading